From: "Martin K. Petersen" <mkp@mkp.net>
To: Jordan Crouse <jordan.crouse@amd.com>
Cc: Jeff Garzik <jeff@garzik.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org
Subject: Re: pata_cs5536: ATA driver for Geode companion chip
Date: Wed, 03 Oct 2007 23:29:26 -0400 [thread overview]
Message-ID: <yq1przva76x.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20071003233012.GA8721@cosmic.amd.com> (Jordan Crouse's message of "Wed\, 3 Oct 2007 17\:30\:12 -0600")
>>>>> "Jordan" == Jordan Crouse <jordan.crouse@amd.com> writes:
Jordan> In the standard AMD VSA, writeos to PCI space 0x48 (DTC), 0x49
Jordan> (CAST) and 0x50 (ETC) should work - and the change should be
Jordan> immediately reflected in the MSR.
I know what the problem is. I just got a BIOS update tonight which
was supposed to fix the issue. However, pata_amd.c still failed
spectacularly at configuring the device whereas pata_cs5536 worked
fine.
For kicks I switched my driver over to using PCI config registers
instead of MSRs. And it still worked!
When I changed my driver I did a quickie conversion from wrmsr() to
pci_write_config_dword(). If I use pci_write_config_byte() instead
(like pata_amd.c), things fail miserably. A register dump reveals
that any value I write becomes a 0. Yay!
--
Martin K. Petersen http://mkp.net/
next prev parent reply other threads:[~2007-10-04 3:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 23:30 pata_cs5536: ATA driver for Geode companion chip Jordan Crouse
2007-10-04 3:29 ` Martin K. Petersen [this message]
2007-10-04 12:04 ` Alan Cox
2007-10-04 15:58 ` Alan Cox
2007-10-04 16:08 ` Jordan Crouse
2007-10-04 16:22 ` Alan Cox
2007-10-04 17:00 ` Martin K. Petersen
2007-10-05 6:05 ` Martin K. Petersen
2007-10-05 6:06 ` [PATCH] pata_cs5536: ATA driver for Geode companion chip (PCI) Martin K. Petersen
2007-10-05 6:07 ` [PATCH] pata_cs5536: ATA driver for Geode companion chip (MSR) Martin K. Petersen
2007-10-05 12:01 ` Alan Cox
2007-10-05 14:53 ` Jordan Crouse
2007-10-05 19:00 ` [PATCH] " Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2007-10-03 17:28 [PATCH 1/1] pata_cs5536: ATA driver for Geode companion chip Martin K. Petersen
2007-10-03 20:31 ` Jordan Crouse
2007-10-03 20:59 ` Alan Cox
2007-10-03 21:18 ` Jordan Crouse
2007-10-03 22:32 ` Martin K. Petersen
2007-10-03 22:56 ` Jeff Garzik
2007-10-10 1:25 ` [PATCH 1/1] " Jeff Garzik
2007-10-10 4:33 ` Martin K. Petersen
2007-10-10 15:20 ` Jordan Crouse
2007-10-10 17:39 ` Andrew Paprocki
2007-10-11 7:22 ` Andrew Paprocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1przva76x.fsf@sermon.lab.mkp.net \
--to=mkp@mkp.net \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=jordan.crouse@amd.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).