From: Antonio Quartulli <antonio@mandelbit.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-iio@vger.kernel.org,
"Jean-Baptiste Maneyrol" <jean-baptiste.maneyrol@tdk.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Subject: Re: [PATCH] iio: imu: inv_icm42600: fix 64bit multiplication
Date: Wed, 16 Jul 2025 21:45:08 +0200 [thread overview]
Message-ID: <018bf0f9-e123-42f9-8817-bf1a597f1f2b@mandelbit.com> (raw)
In-Reply-To: <CAHp75Vcysq584=nVHEB-PqKBtTaL+CCKMEdkM_X0wNOaYzeU=w@mail.gmail.com>
On 16/07/2025 21:38, Andy Shevchenko wrote:
> On Wed, Jul 16, 2025 at 10:22 PM Antonio Quartulli
> <antonio@mandelbit.com> wrote:
>>
>> In inv_icm42600_accel_convert_wom_to_roc() multiplying
>> `threshold` by `convert` may result in a number requiring more
>> than 32bit.
>
> 32 bits
>
>> In this case, although `value` is 64bit wide, the result is
>
> 64-bit
>
>> truncated because the multiplication is performed in the
>> 32bit domain, due to both operands being 32bit long.
>
> 32-bit
> 32-bit
Thanks for highlighting those.
Should I send v2?
Regards,
--
Antonio Quartulli
CEO and Co-Founder
Mandelbit Srl
https://www.mandelbit.com
prev parent reply other threads:[~2025-07-16 19:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 19:22 [PATCH] iio: imu: inv_icm42600: fix 64bit multiplication Antonio Quartulli
2025-07-16 19:36 ` Andy Shevchenko
2025-07-16 19:44 ` Antonio Quartulli
2025-07-16 19:52 ` David Lechner
2025-07-16 20:03 ` Antonio Quartulli
2025-07-17 6:21 ` Andy Shevchenko
2025-07-17 7:50 ` Antonio Quartulli
2025-07-17 12:51 ` Andy Shevchenko
2025-07-16 19:38 ` Andy Shevchenko
2025-07-16 19:45 ` Antonio Quartulli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=018bf0f9-e123-42f9-8817-bf1a597f1f2b@mandelbit.com \
--to=antonio@mandelbit.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jean-baptiste.maneyrol@tdk.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox