From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: accel: mma8452: use pm_ptr() for dev_pm_ops
Date: Tue, 21 Apr 2026 07:23:41 +0530 [thread overview]
Message-ID: <01DD8F0A-6CB9-4C98-91B9-0754E82BC588@gmail.com> (raw)
In-Reply-To: <ad9dd_-lLmazqD5g@ashevche-desk.local>
On 15 April 2026 3:12:15 pm IST, Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
>On Wed, Apr 15, 2026 at 12:50:45AM +0530, Sanjay Chitroda wrote:
>
>> Use pm_ptr() so the PM ops pointer is automatically set to
>> NULL when CONFIG_PM is disabled. This avoids unused-function warnings
>> and follows modern kernel power-management conventions.
>
>...
>
>> static const struct dev_pm_ops mma8452_pm_ops = {
>> SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, pm_runtime_force_resume)
>
>You also want to change this to DEFINE_RUNTIME_DEV_PM_OPS().
>
Hi Andy,
Thank you for the review and feedback.
I will update changes in next version.
Thank,
Sanjay Chitroda
next prev parent reply other threads:[~2026-04-21 2:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 19:20 [PATCH] iio: accel: mma8452: use pm_ptr() for dev_pm_ops Sanjay Chitroda
2026-04-15 9:42 ` Andy Shevchenko
2026-04-21 1:53 ` Sanjay Chitroda [this message]
2026-04-16 15:33 ` kernel test robot
2026-04-20 8:06 ` Geert Uytterhoeven
2026-04-21 1:53 ` Sanjay Chitroda
2026-04-21 15:24 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01DD8F0A-6CB9-4C98-91B9-0754E82BC588@gmail.com \
--to=sanjayembeddedse@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox