From: "Paweł Jarosz" <paweljarosz3691@gmail.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: linux-iio@vger.kernel.org, rui.zhang@intel.com, edubezval@gmail.com
Subject: Re: [PATCH] thermal: generic-adc: Fix linear temperature approximation
Date: Thu, 20 Oct 2016 19:10:33 +0200 [thread overview]
Message-ID: <0412f751-fb88-7b9e-8a8c-501e019de774@gmail.com> (raw)
In-Reply-To: <5808E78B.4060109@nvidia.com>
> Yes please send patch to replace the 1000 with the temp1 - temp2 as
> what you did in your original patch.
> This will fix the non-sequenced (un-equally spaced) temperature table.
replacing 1000 with (temp1 - temp2) is not enough as for example for val
= 9 and table
<7000 8
9000 10>
adc_hi = gti->lookup_table[2 * i - 1];
adc_lo = gti->lookup_table[2 * i + 1];
temp = gti->lookup_table[2 * i];
temp -= (val - adc_lo) * (temp1 - temp2) / (adc_hi - adc_lo);
adc_hi = 8
adc_lo = 10
temp = 9000 - (9 - 10) * (7000 - 9000) / (8 - 10)
temp = 9000 - (-1) * (-2000) / (-2)
temp = 9000 - (-1000) = 10000
and for val = 9 temp should be 8000.
next prev parent reply other threads:[~2016-10-20 17:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 19:31 [PATCH] thermal: generic-adc: Fix linear temperature approximation Paweł Jarosz
2016-10-20 12:40 ` Laxman Dewangan
2016-10-20 14:56 ` Paweł Jarosz
2016-10-20 15:49 ` Laxman Dewangan
2016-10-20 16:14 ` Paweł Jarosz
2016-10-20 16:01 ` Laxman Dewangan
2016-10-20 17:10 ` Paweł Jarosz [this message]
2016-10-20 17:01 ` Laxman Dewangan
2016-10-20 17:26 ` Paweł Jarosz
2016-10-21 6:18 ` Laxman Dewangan
2016-10-21 7:00 ` Paweł Jarosz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0412f751-fb88-7b9e-8a8c-501e019de774@gmail.com \
--to=paweljarosz3691@gmail.com \
--cc=edubezval@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-iio@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox