Linux IIO development
 help / color / mirror / Atom feed
From: Angel Iglesias <ang.iglesiasg@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Paul Cercueil <paul@crapouillou.net>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/5] iio: pressure: bmp280: simplify driver initialization logic
Date: Mon, 11 Jul 2022 14:45:06 +0200	[thread overview]
Message-ID: <046a29a5191c53813ce9477000b07c21ca5699fc.camel@gmail.com> (raw)
In-Reply-To: <YssdPch7dVmRWDbB@smile.fi.intel.com>

On dom, 2022-07-10 at 21:41 +0300, Andy Shevchenko wrote:
> It seems you somehow managed to send patches separately from email
> perspective.
> Make sure you pass parameter --thread to `git format-patch`, so it will create
> a proper chain of emails.

How should I proceed to fix this issue? Should I wait for more feedback and send
a new revision of the patches, now as a proper mail chain? Or should I resend
current patchset as a chain? I don't want to spam the mailing list more due to
my inexperience contributing.

> On Sun, Jul 10, 2022 at 11:17:06AM +0200, Angel Iglesias wrote:
> > Simplified common initialization logic of different sensor types
> > unifying calibration and initial configuration recovery.
> > 
> > Default config param values of each sensor type are stored inside
> > chip_info structure and used to initialize sensor data struct instance.
> > 
> > The auxiliar functions for read each sensor type calibration are converted
> > to a callback available on the chip_info struct.
> 
> > Signed-off-by: Angel Iglesias <ang.iglesiasg@gmail.com>
> > Suggested-by: Jonathan Cameron <jic23@kernel.org>
> 
> Usually this kind of tag goes before your SoB, because it's chronologically
> correct.
> 
Ok, makes sense.

Thank you for your time and help,

Best regards,
Angel

  reply	other threads:[~2022-07-11 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-10  9:17 [PATCH v3 3/5] iio: pressure: bmp280: simplify driver initialization logic Angel Iglesias
2022-07-10 18:41 ` Andy Shevchenko
2022-07-11 12:45   ` Angel Iglesias [this message]
2022-07-11 13:11     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=046a29a5191c53813ce9477000b07c21ca5699fc.camel@gmail.com \
    --to=ang.iglesiasg@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul@crapouillou.net \
    --cc=rafael.j.wysocki@intel.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox