From: David Lechner <dlechner@baylibre.com>
To: Olivier MOYSAN <olivier.moysan@foss.st.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
linux-iio@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: stm32: add oversampling support
Date: Tue, 8 Apr 2025 09:43:11 -0500 [thread overview]
Message-ID: <0550fb58-cff3-47fd-b5f4-cbc19113436c@baylibre.com> (raw)
In-Reply-To: <6d12b6fe-85fb-4345-bf32-02c0fbb1a27a@foss.st.com>
On 4/7/25 11:07 AM, Olivier MOYSAN wrote:
> Hi David,
>
> Thanks for reviewing,
>
> On 4/4/25 18:15, David Lechner wrote:
>> On 4/3/25 11:23 AM, Olivier Moysan wrote:
...
>>> +#define STM32H7_OVSR_MASK GENMASK(25, 16) /* Correspond to OSVR field in datasheet */
>>
>> nit: Comment seems obvious and can be left out.
>>
>
> Oversampling bit name is "OSVR" in datasheet H7, while oversampling shift is "OVSS". For naming consistency, I used OVSR instead of OSVR,
> and highlighted it with a comment. As an alternative, STM32H7_OVSR could be renamed, but I would rather keep it unchanged.
>
Ah, my eyes do not easily see the difference between OSVR and OVSR.
Makes sense to keep it so grep picks up both spellings.
prev parent reply other threads:[~2025-04-08 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-03 16:23 [PATCH v2] iio: adc: stm32: add oversampling support Olivier Moysan
2025-04-04 16:15 ` David Lechner
2025-04-07 16:07 ` Olivier MOYSAN
2025-04-08 14:43 ` David Lechner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0550fb58-cff3-47fd-b5f4-cbc19113436c@baylibre.com \
--to=dlechner@baylibre.com \
--cc=alexandre.torgue@foss.st.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox