Linux IIO development
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>, "Chris Hall" <c-hall@ti.com>,
	"Patrick Edwards" <pedwards@ti.com>,
	"Kurt Borja" <kuurtb@gmail.com>,
	"Nguyen Minh Tien" <zizuzacker@gmail.com>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] iio: adc: ti-ads112c14: add support for I2C CRC8
Date: Fri, 7 Aug 2026 16:18:40 -0500	[thread overview]
Message-ID: <05baac51-bb6c-4a2a-9587-4ae3e30aee21@baylibre.com> (raw)
In-Reply-To: <anUwKGyjjwYxQ8NI@ashevche-desk.local>

On 8/6/26 8:08 PM, Andy Shevchenko wrote:
> On Mon, Jul 27, 2026 at 09:09:50AM -0500, David Lechner (TI) wrote:
>> Add support for I2C CRC8 to the TI ADS112C14 ADC driver. This verifies
>> data integrity of all I2C transactions with the device.
>>
>> For now, it is always enabled, but it could be made optional in the
>> future if needed (e.g. for higher-speed data acquisition).
> 
> ...
> 
>> +static int ads112c14_i2c_add_driver(struct i2c_driver *driver)
>> +{
>> +	crc8_populate_msb(ads112c14_crc8_table, ADS112C14_I2C_CRC8_POLYNOMIAL);
>> +
>> +	return i2c_add_driver(driver);
>> +}
>> +
>>  static struct i2c_driver ads112c14_driver = {
>>  	.driver = {
>>  		.name = "ads112c14",
>> @@ -1217,7 +1347,7 @@ static struct i2c_driver ads112c14_driver = {
>>  	.probe = ads112c14_probe,
>>  	.id_table = ads112c14_id,
>>  };
>> -module_i2c_driver(ads112c14_driver);
>> +module_driver(ads112c14_driver, ads112c14_i2c_add_driver, i2c_del_driver);
> 
> This is not needed if you call crc8_populate_msb() from the probe using
> DO_ONCE_SLEEPABLE().
> 

Good idea, but this series got picked up already.


  reply	other threads:[~2026-08-07 21:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-27 14:09 [PATCH v3 0/2] iio: adc: ti-ads112c14: buffered read support David Lechner (TI)
2026-07-27 14:09 ` [PATCH v3 1/2] iio: adc: ti-ads112c14: add support for I2C CRC8 David Lechner (TI)
2026-08-07  1:08   ` Andy Shevchenko
2026-08-07 21:18     ` David Lechner [this message]
2026-08-15  1:35       ` Jonathan Cameron
2026-08-17  7:47         ` Andy Shevchenko
2026-07-27 14:09 ` [PATCH v3 2/2] iio: adc: ti-ads112c14: add support for buffered read David Lechner (TI)
2026-08-01  1:47 ` [PATCH v3 0/2] iio: adc: ti-ads112c14: buffered read support Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05baac51-bb6c-4a2a-9587-4ae3e30aee21@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=c-hall@ti.com \
    --cc=jic23@kernel.org \
    --cc=kuurtb@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=pedwards@ti.com \
    --cc=zizuzacker@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox