From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>
Cc: "jic23@kernel.org" <jic23@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Emil Gedenryd <emil.gedenryd@axis.com>,
Andreas Dannenberg <dannenberg@ti.com>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] dt-bindings: iio: light: opt3001: add compatible for opt3004
Date: Sun, 29 Dec 2024 10:45:44 +0100 [thread overview]
Message-ID: <0a0e9d97-26f2-45b1-a783-fabcbb9e1c05@kernel.org> (raw)
In-Reply-To: <PN0P287MB2843E7005997F1728B0F9B2CFF0F2@PN0P287MB2843.INDP287.PROD.OUTLOOK.COM>
On 28/12/2024 11:54, Hardevsinh Palaniya wrote:
>>> - Reverse the order of compatible string
>>>
>>> v1 -> v2:
>>>
>>> - Use fallback mechanism for the OPT3004.
>>> - Drop 2/2 patch from the patch series[1] as per feedback.
>>>
>>> Link[1]: https://lore.kernel.org/linux-iio/20241224061321.6048-1-hardevsinh.palaniya@siliconsignals.io/T/#t
>>
>>
>> And where is any user of this, the DTS? We don't take bindings just
>> because there is such device out there.
>>
>> I looked and nothing:
>> https://lore.kernel.org/all/?q=ti%2Copt3004
>
> I added compatibility for the OPT3004 into the driver. However,
> based on Andy's feedback, it seems there might not be a need
> to include this directly in the driver.
> (Refer to Link [1] from the changelog.)
>
> we could follow a similar approach to how we handled the ADXL346,
> by just adding it to the bindings, since the ADXL346 is similar to the
> ADXL345.
Sure, I am not talking about this. I am looking for a user of the
binding. Where is one?
User is any piece of *upstream* project which uses the binding.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-12-29 9:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 13:11 [PATCH v3] dt-bindings: iio: light: opt3001: add compatible for opt3004 Hardevsinh Palaniya
2024-12-28 10:14 ` Krzysztof Kozlowski
2024-12-28 10:54 ` Hardevsinh Palaniya
2024-12-28 13:19 ` Jonathan Cameron
2024-12-30 7:34 ` Hardevsinh Palaniya
2025-01-02 21:34 ` Rob Herring
2025-01-04 12:45 ` Jonathan Cameron
2024-12-29 9:45 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a0e9d97-26f2-45b1-a783-fabcbb9e1c05@kernel.org \
--to=krzk@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=dannenberg@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=emil.gedenryd@axis.com \
--cc=hardevsinh.palaniya@siliconsignals.io \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox