From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3E470255F2C for ; Sat, 11 Jul 2026 15:09:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782597; cv=none; b=horZjavIX5rmIeB3Wm4NUtOsaoIyk/7A5m8Wc9ocrAK8H8oPhcqTVvtSX6IHv0l1ZHB1iWFDCTKfVW6jdu747ff4ovp/bCqLXeVKhHpjFWCuITgLU8fnaWHJo6gnRrz/JHF+lYIjO34j1guv8EyamV3yLHYdj6Ky4HmQ15RBK3A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783782597; c=relaxed/simple; bh=u656KmwHS2NuwcwmZgMH2DXucDEuVNMw+znBt3qpx2Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u4Rg/d6w5XdX19bWrsb0Jg16IMhDkcoqqCq9dPpjrWnInxPiK1gXyWBBnGxIe1GIABmopC1EsRDf2dbllfIIzpUsbMGx+TmYPze0jCe2F/0MtH2dHjH8rkbw+gyuTn9VRq+sWNsLGgjA5kuyuUdOon0c+E7OHx87qEOqsbVSk50= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=BesgDaNj; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="BesgDaNj" Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7e9ecb1e13cso1598906a34.3 for ; Sat, 11 Jul 2026 08:09:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1783782595; x=1784387395; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=nr0soaAtqthPp2U17XEZK/Vr4kfG1VMxAbHUIXSh0Dc=; b=BesgDaNjNQYR+jKIUeO95DXLO7HZIlzux01aKseMB+0HxqCGKgU+74uGM9z1QDPA6A C9C/D6ZKcjQslnOp3+ONoVHoNVIScnRNiUKZMHRhbiGclV+woARoyTuAJ6U4rYo/PMYz 54Dk4ql8ihuxIg69M69LwFW0Sl4AviGoTXgCXnwA5vdFEEVpHUSsJozLT+BAdRD/nSAN rh1Of8Yul+Bc6Uvq1Ee3qMlpbOLfTVSn7rz85xC0k1oU5O87r8XocBptL69BQQJMqBFk 6eBTQV5vqSQkuEW8fP3cWY2pLp+WeWhH5VXzmbsH3kP/GArcv6RI2rJlY7TpBrOQgx8z ngPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783782595; x=1784387395; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nr0soaAtqthPp2U17XEZK/Vr4kfG1VMxAbHUIXSh0Dc=; b=SersnZZwBGskEi7xjNAo5Gr1Y1czxwLPlu7+3r35Sso3Ja67dilKkGMuSRCAz9QKgc Fm2vfXXDbC4UNHT+crTzlBLwTpXjtxNstSwWaLl1HOyKRjv0AJnJ7tCfUpKDUTG5jo71 fa4Beu4eDuHLVxfWAsn85kcw+GreRE0UdhyuGwfg/w7jgasPDObUniKr3E1NuyJyQotM DeMXjwasDl8bw2apvDUooBg2kGVk6C+813k67dSz8DfvP1JnMqI6maPsyHIr5Z2HtmSO iXPwEld1vcRF4UZAsHqaW18r94Mj1dsrPFLO2CU2+z36PVbKahJ0WfpFzEzOzsrJQtvo XhDQ== X-Forwarded-Encrypted: i=1; AFNElJ8rTyEYL0jrMAycL3mEyg4daAMCgaPTVn6E3MEMH4Cu6yTKw5pAXBa2KXenfuGBIA9rOoA10ZnWJzo=@vger.kernel.org X-Gm-Message-State: AOJu0YyKivII+DSaeJMXkJa0BwjF53JpGBsPLcyg5oQUm/luPSNM49Bf 1/CvxoXjbPX//N4m/nMM7d9xXHgcViWZ3s1r/DVpdRe8Yg4hAWOVUYWpfKt/R+ACWpM= X-Gm-Gg: AfdE7cms8mmmKcZMFziKX5mX0W9MwW7NawQTPOtSFvTjrlpnmhX921agh9DRM4ekiqv vFKH1ycD2R56R4uKSzTT/Hq3Ev9/h0ayGrwz+ESGHzZN3uKugOkgzCclDhv6sbEl3czLZEucBq6 1u1Qzri1Y6jDTMu/29GQvqZs9kuP15AOZB6r/xfzjbU7Tu5ad0W2/746o61ypPeEnQQ1F1rMjXK sPDyVrAXGIE9Kkw3PdtuxnZE43VnCbnGQZjjyr+9fnAtXHrIQjOoBqnF9DXwerjaurbiHoGaszp jD57zc3IMlr6Efn5lOPq9L98ZxONpKxBzw8D6H711auRrbcfrYHUPl+SFb1y9U5iNwSo2yc0sCO SgEEojq3o6Ko33ue5y48aBos8KQU/HZXTJ1D74dLhKauYiJHsea75BGxzbeeqAe9Qivyn1/BmFU Uloy4BOQPlleay8mNqY4ctlPCPS0wmX/LdQjzpveL0NPLyNVJnFpzqOoVXiP2DacqZrl6bKZ9MU g== X-Received: by 2002:a05:6830:2309:b0:7e9:e5c0:e0a with SMTP id 46e09a7af769-7ec095c68cdmr2096634a34.5.1783782595189; Sat, 11 Jul 2026 08:09:55 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:a950:74e5:81f2:8c89? ([2600:8803:e7e4:500:a950:74e5:81f2:8c89]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7ebcae1dddbsm8558095a34.1.2026.07.11.08.09.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Jul 2026 08:09:53 -0700 (PDT) Message-ID: <0b513d21-31e5-497a-9332-7efc3fd3e010@baylibre.com> Date: Sat, 11 Jul 2026 10:09:51 -0500 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 5/7] iio: dac: ad5686: read_raw/write_raw: use guard(mutex)() To: rodrigo.alencar@analog.com, Michael Auchter , linux@analog.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Cc: Michael Hennerich , Jonathan Cameron , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kees Cook , "Gustavo A. R. Silva" , Maxwell Doose , Joshua Crofts References: <20260710-ad5686-new-features-v7-0-1bcc8c280e4d@analog.com> <20260710-ad5686-new-features-v7-5-1bcc8c280e4d@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260710-ad5686-new-features-v7-5-1bcc8c280e4d@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/10/26 6:20 AM, Rodrigo Alencar via B4 Relay wrote: > From: Rodrigo Alencar > > Use guarded mutex lock to facilitate code review when adding new > attributes. This will allow for early returns, avoiding error-prone > locking and unlocking in error paths. This also adds missing include > linux/cleanup.h. Gain-control support will allow the scale attribute > to be configurable. > > Reviewed-by: Maxwell Doose > Reviewed-by: Joshua Crofts > Signed-off-by: Rodrigo Alencar > --- > drivers/iio/dac/ad5686.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c > index 316f9ccf54d9..df32f46db81e 100644 > --- a/drivers/iio/dac/ad5686.c > +++ b/drivers/iio/dac/ad5686.c > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -177,11 +178,11 @@ static int ad5686_read_raw(struct iio_dev *indio_dev, > struct ad5686_state *st = iio_priv(indio_dev); > int ret; > > + guard(mutex)(&st->lock); The commit message should explain why the location we are taking the lock has moved. Although, I don't see a reason to move it. > + > switch (m) { > case IIO_CHAN_INFO_RAW: > - mutex_lock(&st->lock); > ret = ad5686_read(st, chan->address); > - mutex_unlock(&st->lock); > if (ret < 0) > return ret; > *val = (ret >> chan->scan_type.shift) & > @@ -202,23 +203,19 @@ static int ad5686_write_raw(struct iio_dev *indio_dev, > long mask) > { > struct ad5686_state *st = iio_priv(indio_dev); > - int ret; > + > + guard(mutex)(&st->lock); > > switch (mask) { > case IIO_CHAN_INFO_RAW: > if (val >= (1 << chan->scan_type.realbits) || val < 0) > return -EINVAL; > > - mutex_lock(&st->lock); > - ret = ad5686_write(st, AD5686_CMD_WRITE_INPUT_N_UPDATE_N, > - chan->address, val << chan->scan_type.shift); > - mutex_unlock(&st->lock); > - break; > + return ad5686_write(st, AD5686_CMD_WRITE_INPUT_N_UPDATE_N, > + chan->address, val << chan->scan_type.shift); > default: > - ret = -EINVAL; > + return -EINVAL; > } > - > - return ret; > } > > static const struct iio_info ad5686_info = { >