From: Jonathan Cameron <jic23@kernel.org>
To: Quentin Swain <dudebrobro179@gmail.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [PATCH] Fix check-patch symbolic permissions warnings
Date: Sun, 30 Apr 2017 17:23:26 +0100 [thread overview]
Message-ID: <0c04f7ec-2412-c5b6-936b-42bb6023dfc2@kernel.org> (raw)
In-Reply-To: <85a3789a-ec2b-67aa-88c7-3a66f0cf1eee@kernel.org>
On 30/04/17 17:22, Jonathan Cameron wrote:
> On 29/04/17 00:03, Quentin Swain wrote:
> A short description of why would have been good.
>
> Anyhow, applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.
oops. I didn't check my git output. A similar patch has already
been applied.
Sorry about that!
Jonathan
>
> Thanks,
>
> Jonathan
>> ---
>> drivers/staging/iio/light/tsl2x7x_core.c | 20 ++++++++++----------
>> 1 file changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/staging/iio/light/tsl2x7x_core.c b/drivers/staging/iio/light/tsl2x7x_core.c
>> index af3910b..c63fe6a 100644
>> --- a/drivers/staging/iio/light/tsl2x7x_core.c
>> +++ b/drivers/staging/iio/light/tsl2x7x_core.c
>> @@ -1498,34 +1498,34 @@ static int tsl2x7x_write_raw(struct iio_dev *indio_dev,
>> return 0;
>> }
>>
>> -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
>> +static DEVICE_ATTR(power_state, 0644,
>> tsl2x7x_power_state_show, tsl2x7x_power_state_store);
>>
>> -static DEVICE_ATTR(in_proximity0_calibscale_available, S_IRUGO,
>> +static DEVICE_ATTR(in_proximity0_calibscale_available, 0444,
>> tsl2x7x_prox_gain_available_show, NULL);
>>
>> -static DEVICE_ATTR(in_illuminance0_calibscale_available, S_IRUGO,
>> +static DEVICE_ATTR(in_illuminance0_calibscale_available, 0444,
>> tsl2x7x_gain_available_show, NULL);
>>
>> -static DEVICE_ATTR(in_illuminance0_integration_time, S_IRUGO | S_IWUSR,
>> +static DEVICE_ATTR(in_illuminance0_integration_time, 0644,
>> tsl2x7x_als_time_show, tsl2x7x_als_time_store);
>>
>> -static DEVICE_ATTR(in_illuminance0_target_input, S_IRUGO | S_IWUSR,
>> +static DEVICE_ATTR(in_illuminance0_target_input, 0644,
>> tsl2x7x_als_cal_target_show, tsl2x7x_als_cal_target_store);
>>
>> -static DEVICE_ATTR(in_illuminance0_calibrate, S_IWUSR, NULL,
>> +static DEVICE_ATTR(in_illuminance0_calibrate, 0200, NULL,
>> tsl2x7x_do_calibrate);
>>
>> -static DEVICE_ATTR(in_proximity0_calibrate, S_IWUSR, NULL,
>> +static DEVICE_ATTR(in_proximity0_calibrate, 0200, NULL,
>> tsl2x7x_do_prox_calibrate);
>>
>> -static DEVICE_ATTR(in_illuminance0_lux_table, S_IRUGO | S_IWUSR,
>> +static DEVICE_ATTR(in_illuminance0_lux_table, 0644,
>> tsl2x7x_luxtable_show, tsl2x7x_luxtable_store);
>>
>> -static DEVICE_ATTR(in_intensity0_thresh_period, S_IRUGO | S_IWUSR,
>> +static DEVICE_ATTR(in_intensity0_thresh_period, 0644,
>> tsl2x7x_als_persistence_show, tsl2x7x_als_persistence_store);
>>
>> -static DEVICE_ATTR(in_proximity0_thresh_period, S_IRUGO | S_IWUSR,
>> +static DEVICE_ATTR(in_proximity0_thresh_period, 0644,
>> tsl2x7x_prox_persistence_show, tsl2x7x_prox_persistence_store);
>>
>> /* Use the default register values to identify the Taos device */
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2017-04-30 16:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 23:03 Fix permissions warning from check-patch for tsl2x7x Quentin Swain
2017-04-28 23:03 ` [PATCH] Fix check-patch symbolic permissions warnings Quentin Swain
2017-04-30 16:22 ` Jonathan Cameron
2017-04-30 16:23 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c04f7ec-2412-c5b6-936b-42bb6023dfc2@kernel.org \
--to=jic23@kernel.org \
--cc=dudebrobro179@gmail.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox