From: David Lechner <dlechner@baylibre.com>
To: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>, linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, "Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
linux-iio@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] iio: Use dev_fwnode()
Date: Wed, 11 Jun 2025 08:57:30 -0500 [thread overview]
Message-ID: <0ec0fd5e-8fbe-43c4-8aad-f36d2872f280@baylibre.com> (raw)
In-Reply-To: <20250611104348.192092-9-jirislaby@kernel.org>
Subject should be "iio: adc: stm32-adc: Use dev_fwnode()"
On 6/11/25 5:43 AM, Jiri Slaby (SUSE) wrote:
> irq_domain_create_simple() takes fwnode as the first argument. It can be
> extracted from the struct device using dev_fwnode() helper instead of
> using of_node with of_fwnode_handle().
>
> So use the dev_fwnode() helper.
>
...
> @@ -421,10 +420,8 @@ static int stm32_adc_irq_probe(struct platform_device *pdev,
> return priv->irq[i];
> }
>
> - priv->domain = irq_domain_create_simple(of_fwnode_handle(np),
> - STM32_ADC_MAX_ADCS, 0,
> - &stm32_adc_domain_ops,
> - priv);
> + priv->domain = irq_domain_create_simple(dev_fwnode(&pdev->dev), STM32_ADC_MAX_ADCS, 0,
> + &stm32_adc_domain_ops, priv);
In the IIO subsystem, we still usually wrap at 80 characters so
wouldn't want to unwrap the lines here.
> if (!priv->domain) {
> dev_err(&pdev->dev, "Failed to add irq domain\n");
> return -ENOMEM;
next prev parent reply other threads:[~2025-06-11 13:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250611104348.192092-1-jirislaby@kernel.org>
2025-06-11 10:43 ` [PATCH] iio: Use dev_fwnode() Jiri Slaby (SUSE)
2025-06-11 13:57 ` David Lechner [this message]
2025-06-12 8:46 ` [PATCH v2] iio: adc: stm32-adc: " Jiri Slaby (SUSE)
2025-06-13 17:00 ` David Lechner
2025-06-14 11:08 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ec0fd5e-8fbe-43c4-8aad-f36d2872f280@baylibre.com \
--to=dlechner@baylibre.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andy@kernel.org \
--cc=jic23@kernel.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nuno.sa@analog.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox