From: Jonathan Cameron <jic23@kernel.org>
To: Crestez Dan Leonard <cdleonard@gmail.com>,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Michael Welling <mwelling@ieee.org>,
mranostay@gmail.com
Cc: linux-kernel@vger.kernel.org, daniel.baluta@intel.com,
linux-iio@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>
Subject: Re: Regression in inv_mpu6050: 4.6.0-rc5
Date: Wed, 4 May 2016 08:49:06 +0100 [thread overview]
Message-ID: <0fd48340-63b7-253e-352c-4f98cf6e19b2@kernel.org> (raw)
In-Reply-To: <5728F3CD.3000801@gmail.com>
On 03/05/16 19:54, Crestez Dan Leonard wrote:
> On 05/01/2016 10:58 PM, Jonathan Cameron wrote:
>> On 27/04/16 16:56, One Thousand Gnomes wrote:
>>> On Tue, 26 Apr 2016 18:07:55 -0500
>>> Michael Welling <mwelling@ieee.org> wrote:
>>>
>>>> On Tue, Apr 26, 2016 at 11:26:51PM +0100, One Thousand Gnomes wrote:
>>>>>
>>>>> This now causes us to crash and burn on the ASUS T100TA Baytrail/T
>>>>> platforms
>>>>>
>>>>
>>>> I believe this regression has already been patched.
>>>>
>>>> Check the latest commits in linux-next.
>>>>
>>>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/log/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
>>>>
>>>> See if the latest patches fix your issue.
>>>
>>> It does - as this is a regression can we please get those fixes into the
>>> next -rc ?
>>>
>> I'm afraid I'm lost in this one - which patch caused the regression and
>> which one fixed it? The only patches I can immediately see in next
>> both introduce and then squish a similar bug, but neither of them
>> has hit Linus' tree yet.
>>
>> Or are we dealing with what was fixed in:
>> c816d9e7 iio: imu: mpu6050: fix possible NULL dereferences
>> I had understood that one as more hypothetical than real...
>>
>> Unfortunately I'm travelling and I suspect that means this will only get
>> in just after the release (so for 4.6.1) once I've confirmed which fixes
>> we actually need to backport.
>>
> Commit
> c816d9e7: iio: imu: mpu6050: fix possible NULL dereferences
> Fixes:
> 33da559f: iio: imu: mpu6050: add mpu6500 register settings
>
> As far as I can tell this crash will always happen when the device is
> probed via ACPI.
Hi Greg,
A quick heads up.
Unfortunately this regression has come up whilst I'm travelling and
don't have appropriate signing keys with me to do a pull request.
Should be able to do one tomorrow evening as I'll back home.
Turns out the 'possible' is quite common and causing a mess.
Even better the fix actually has a fix as well...
Fastest option is probably a cherry pick of:
c816d9e7: iio: imu: mpu6050: fix possible NULL dereferences
718ba46e: iio: imu: mpu6050: Fix name/chip_id when using ACPI
I'll send you a pull request of my
togreg-in-a-hurry branch tomorrow.
Sorry for these being so late in the cycle.
Anyhow, run for train time.
Thanks
Jonathan
next prev parent reply other threads:[~2016-05-04 7:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160426232651.099a18d7@lxorguk.ukuu.org.uk>
2016-04-26 23:07 ` Regression in inv_mpu6050: 4.6.0-rc5 Michael Welling
2016-04-27 15:56 ` One Thousand Gnomes
2016-05-01 19:58 ` Jonathan Cameron
2016-05-03 18:54 ` Crestez Dan Leonard
2016-05-04 7:49 ` Jonathan Cameron [this message]
2016-05-04 17:24 ` Greg KH
2016-05-04 18:15 ` Jonathan Cameron
2016-05-05 19:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0fd48340-63b7-253e-352c-4f98cf6e19b2@kernel.org \
--to=jic23@kernel.org \
--cc=cdleonard@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mranostay@gmail.com \
--cc=mwelling@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).