From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Tzung-Bi Shih <tzungbi@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-iio@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] iio: cros_ec: Avoid -Wflex-array-member-not-at-end warning
Date: Mon, 17 Mar 2025 15:10:38 +1030 [thread overview]
Message-ID: <112490dd-4490-44f4-abd2-07f7a519aa7b@embeddedor.com> (raw)
In-Reply-To: <Z9d7rp-ullvmXKoM@google.com>
On 17/03/25 12:02, Tzung-Bi Shih wrote:
> On Mon, Mar 17, 2025 at 11:24:59AM +1030, Gustavo A. R. Silva wrote:
>> static int cros_ec_get_host_cmd_version_mask(struct cros_ec_device *ec_dev,
>> u16 cmd_offset, u16 cmd, u32 *mask)
>> {
>> + DEFINE_RAW_FLEX(struct cros_ec_command, buf, data,
>> + sizeof(struct ec_response_get_cmd_versions));
>
> max(sizeof(struct ec_params_get_cmd_versions),
> sizeof(struct ec_response_get_cmd_versions))?
I considered that, but DEFINE_RAW_FLEX() complains about it due to the
_Static_assert(__builtin_constant_p(count), \
"onstack flex array members require compile-time const count");
--
Gustavo
next prev parent reply other threads:[~2025-03-17 4:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-17 0:54 [PATCH][next] iio: cros_ec: Avoid -Wflex-array-member-not-at-end warning Gustavo A. R. Silva
2025-03-17 1:32 ` Tzung-Bi Shih
2025-03-17 4:40 ` Gustavo A. R. Silva [this message]
2025-03-17 12:04 ` Jonathan Cameron
2025-03-18 1:51 ` Tzung-Bi Shih
2025-03-18 8:18 ` Kees Cook
2025-03-18 10:05 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=112490dd-4490-44f4-abd2-07f7a519aa7b@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox