Linux IIO development
 help / color / mirror / Atom feed
From: <gregkh@suse.de>
To: jic23@cam.ac.uk,gregkh@suse.de,linux-iio@vger.kernel.org
Subject: patch staging-iio-ring_sw-fix-incorrect-test-on-successful-read-of-last-value-causes-infinite-loop.patch added to gregkh-2.6 tree
Date: Thu, 22 Apr 2010 17:13:21 -0700	[thread overview]
Message-ID: <1271981601503@kroah.org> (raw)
In-Reply-To: <4BB22A90.6070801@cam.ac.uk>


This is a note to let you know that I've just added the patch titled

    Subject: staging: iio: ring_sw: Fix incorrect test on successful read=
 of last value, causes infinite loop

to my gregkh-2.6 tree.  Its filename is

    staging-iio-ring_sw-fix-incorrect-test-on-successful-read-of-last-val=
ue-causes-infinite-loop.patch

This tree can be found at=20
    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patch=
es/


>>From jic23@cam.ac.uk  Thu Apr 22 16:41:09 2010
From: Jonathan Cameron <jic23@cam.ac.uk>
Date: Tue, 30 Mar 2010 17:45:04 +0100
Subject: staging: iio: ring_sw: Fix incorrect test on successful read of =
last value, causes infinite loop
To: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>, Greg Kroah-H=
artman <gregkh@suse.de>
Message-ID: <4BB22A90.6070801@cam.ac.uk>


This is a bad one. The test means that almost no reads of the last
value ever succeed!  Result is an infinite loop.

Another one for the 'oops' category.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/staging/iio/ring_sw.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/iio/ring_sw.c
+++ b/drivers/staging/iio/ring_sw.c
@@ -293,7 +293,7 @@ again:
 		return -EAGAIN;
 	memcpy(data, last_written_p_copy, ring->buf.bpd);
=20
-	if (unlikely(ring->last_written_p >=3D last_written_p_copy))
+	if (unlikely(ring->last_written_p !=3D last_written_p_copy))
 		goto again;
=20
 	iio_unmark_sw_rb_in_use(&ring->buf);

      reply	other threads:[~2010-04-23  0:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-30 16:45 [PATCH] Fix staging:iio:ring_sw: Fix incorrect test on successful read of last value, causes infinite loop Jonathan Cameron
2010-04-23  0:13 ` gregkh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271981601503@kroah.org \
    --to=gregkh@suse.de \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox