From: "Nuno Sá" <noname.nuno@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Drew Fustini" <drew@pdp7.com>
Subject: Re: [PATCH 1/2] iio: ltc2983: add support for optional reset gpio
Date: Mon, 23 Aug 2021 16:51:22 +0200 [thread overview]
Message-ID: <12d40e96658a005d857a49eccede2ac9620c5e2d.camel@gmail.com> (raw)
In-Reply-To: <CAHp75Vcu47BUKPVVtJK0U4G5_6ey-U=o5yDjCH43Nz7TsH+NMA@mail.gmail.com>
On Mon, 2021-08-23 at 17:27 +0300, Andy Shevchenko wrote:
> On Mon, Aug 23, 2021 at 3:51 PM Nuno Sá <noname.nuno@gmail.com>
> wrote:
> > On Mon, 2021-08-23 at 14:14 +0300, Andy Shevchenko wrote:
> > > On Fri, Aug 20, 2021 at 9:53 AM Nuno Sá <nuno.sa@analog.com>
> > > wrote:
> > > > Check if an optional reset gpio is present and if so, make sure
> > > > to
> > > > reset
> > > > the device.
> > >
> > > ...
> > >
> > > > + usleep_range(1000, 1005);
> > >
> > > The delta should be at least 20%, otherwise I'm not sure why such
> > > a
> > > strict range?
> > >
> >
> > No special reason... I just had no hard requirement for delta so I
> > just
> > gave something small. Is 20% documented anywhere?
>
> Quick search shows nothing, but I remember I saw it somewhere.
> So, the explanation is empirical, because the idea behind is to allow
> less HRT interrupts. When you do a tough margin, you may generate too
> many interrupts from the timer. So, 20% seems like a good balance for
> most of the values.
>
I see, that makes sense to me.
> The parameters to take into account are:
> - minimum (or maybe rather median?) CPU frequency the code will be
> run on
> - minimal sleep (for small sleeps even better to have udelay() as I
> believe documented in timers.rst, for bigger sleeps, like 10ms the
> margin can be 10% or so)
udelay() would be for sleeps < 10us
- Nuno Sá
prev parent reply other threads:[~2021-08-23 14:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 6:55 [PATCH 1/2] iio: ltc2983: add support for optional reset gpio Nuno Sá
2021-08-20 6:55 ` [PATCH 2/2] iio: ltc2983: fail probe if no channels are given Nuno Sá
2021-08-20 8:22 ` Alexandru Ardelean
2021-08-20 8:21 ` [PATCH 1/2] iio: ltc2983: add support for optional reset gpio Alexandru Ardelean
2021-08-20 9:29 ` Sa, Nuno
2021-08-20 18:58 ` Alexandru Ardelean
2021-08-23 7:04 ` Sa, Nuno
2021-08-25 8:24 ` Sa, Nuno
2021-08-23 11:14 ` Andy Shevchenko
2021-08-23 12:51 ` Nuno Sá
2021-08-23 14:27 ` Andy Shevchenko
2021-08-23 14:51 ` Nuno Sá [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12d40e96658a005d857a49eccede2ac9620c5e2d.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=drew@pdp7.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).