linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@cam.ac.uk>
To: broonie@opensource.wolfsonmicro.com
Cc: linux-kernel@vger.kernel.org, Michael.Hennerich@analog.com,
	linux-iio@vger.kernel.org, Jonathan Cameron <jic23@cam.ac.uk>
Subject: [RFC PATCH 0/2 V2] Using regmap with ADIS devices.
Date: Thu,  8 Sep 2011 15:09:22 +0100	[thread overview]
Message-ID: <1315490964-25718-1-git-send-email-jic23@cam.ac.uk> (raw)

Hi Mark,

I've tried your suggestion of doing things at the marshalling level
and would be interested to hear what you think of the result.

Note these patches are not clean yet hence no sign offs.

The tricky bit was triggering the two separate writes per register
and the result is somewhat hacky.

An alternative there would be to add some configuration options to
the spi_write (or allow a couple of varients) so as to break the
long transfer that would generate up and hence bounce the cs line
in the right place.  Gah. SPI can be so uggly sometimes.

If this approach isn't acceptable in principle I'll give up and
conclude that these parts will never play well! (which is fine
by me if true).

Jonathan

Jonathan Cameron (2):
  regmap: Support half writes and padding between register and value.
  staging:iio:imu:adis16400 regmap introduction.

 drivers/base/regmap/internal.h           |    1 +
 drivers/base/regmap/regmap.c             |   42 ++++-
 drivers/staging/iio/imu/Kconfig          |    1 +
 drivers/staging/iio/imu/adis16400.h      |    2 +
 drivers/staging/iio/imu/adis16400_core.c |  301 +++++++++++++++++++-----------
 include/linux/regmap.h                   |    6 +
 6 files changed, 234 insertions(+), 119 deletions(-)

-- 
1.7.3.4

             reply	other threads:[~2011-09-08 14:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08 14:09 Jonathan Cameron [this message]
2011-09-08 14:09 ` [PATCH 1/2] regmap: Support half writes and padding between register and value Jonathan Cameron
2011-09-08 16:27   ` Mark Brown
2011-09-09  9:44     ` Jonathan Cameron
2011-09-09 16:14       ` Mark Brown
2011-09-09 16:30         ` Jonathan Cameron
2011-09-09 16:30           ` Mark Brown
2011-09-08 14:09 ` [PATCH 2/2] staging:iio:imu:adis16400 regmap introduction Jonathan Cameron
2011-09-08 16:30   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1315490964-25718-1-git-send-email-jic23@cam.ac.uk \
    --to=jic23@cam.ac.uk \
    --cc=Michael.Hennerich@analog.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).