From: Jonathan Cameron <jic23@cam.ac.uk>
To: greg@kroah.com
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@cam.ac.uk>
Subject: [PATCH 0/2] staging:iio: two fixes
Date: Fri, 14 Oct 2011 14:46:57 +0100 [thread overview]
Message-ID: <1318600019-11809-1-git-send-email-jic23@cam.ac.uk> (raw)
Max1363 is a silly allocation size bug.
The other big one is a case of the previous single unregister freee
function meaning there was no valid place to free certain arrays
used in the sysfs attribute registration.
Original messages:
max one was just a raw patch as it is obvious.
The other was:
No idea why this hasn't caused me more issues before today
(when everything started dying).
Anyhow, it was impossible to correctly cleanup buffer related
sysfs attribute arrays as it could not be before the
iio_device_unregister as then the actual file removal
would be using freeded memory.
It could not be after as then we didn't have any way of getting
to it.
Fix is to resplit iio_device_unregister in two and do the
free explicitly in all drivers.
If people can test as many parts as possible asap, I'll
be pushing this onwards as soon as I'm happy I haven't
caused any more fallout.
Note along the way I fixed a few removal paths that wouldn't
have worked anyway.
Thanks,
Jonathan
Jonathan Cameron (2):
staging:iio: fix removal path to allow correct freeing.
staging:iio:adc:max1363 incorrect allocation of available_scanmasks
drivers/staging/iio/accel/adis16201_core.c | 3 +-
drivers/staging/iio/accel/adis16203_core.c | 3 +-
drivers/staging/iio/accel/adis16204_core.c | 3 +-
drivers/staging/iio/accel/adis16209_core.c | 3 +-
drivers/staging/iio/accel/adis16220_core.c | 13 +++++------
drivers/staging/iio/accel/adis16240_core.c | 3 +-
drivers/staging/iio/accel/kxsd9.c | 1 +
drivers/staging/iio/accel/lis3l02dq_core.c | 7 +++--
drivers/staging/iio/accel/sca3000_core.c | 13 +++++------
drivers/staging/iio/adc/ad7150.c | 3 +-
drivers/staging/iio/adc/ad7152.c | 1 +
drivers/staging/iio/adc/ad7192.c | 26 ++++++++--------------
drivers/staging/iio/adc/ad7280a.c | 19 ++++++++--------
drivers/staging/iio/adc/ad7291.c | 4 ++-
drivers/staging/iio/adc/ad7298_core.c | 4 +-
drivers/staging/iio/adc/ad7476_core.c | 3 +-
drivers/staging/iio/adc/ad7606_core.c | 3 +-
drivers/staging/iio/adc/ad7746.c | 1 +
drivers/staging/iio/adc/ad7780.c | 3 +-
drivers/staging/iio/adc/ad7793.c | 3 +-
drivers/staging/iio/adc/ad7816.c | 3 +-
drivers/staging/iio/adc/ad7887_core.c | 3 +-
drivers/staging/iio/adc/ad799x_core.c | 3 +-
drivers/staging/iio/adc/adt7310.c | 3 +-
drivers/staging/iio/adc/adt7410.c | 3 +-
drivers/staging/iio/adc/adt75.c | 3 +-
drivers/staging/iio/adc/max1363_core.c | 5 ++-
drivers/staging/iio/addac/adt7316.c | 3 +-
drivers/staging/iio/dac/ad5446.c | 9 ++++---
drivers/staging/iio/dac/ad5504.c | 4 +-
drivers/staging/iio/dac/ad5624r_spi.c | 3 +-
drivers/staging/iio/dac/ad5686.c | 4 +-
drivers/staging/iio/dac/ad5791.c | 5 +--
drivers/staging/iio/dds/ad5930.c | 1 +
drivers/staging/iio/dds/ad9832.c | 9 ++++---
drivers/staging/iio/dds/ad9834.c | 8 +++---
drivers/staging/iio/dds/ad9850.c | 1 +
drivers/staging/iio/dds/ad9852.c | 1 +
drivers/staging/iio/dds/ad9910.c | 1 +
drivers/staging/iio/dds/ad9951.c | 1 +
drivers/staging/iio/gyro/adis16060_core.c | 1 +
drivers/staging/iio/gyro/adis16080_core.c | 1 +
drivers/staging/iio/gyro/adis16130_core.c | 1 +
drivers/staging/iio/gyro/adis16260_core.c | 4 ++-
drivers/staging/iio/gyro/adxrs450_core.c | 11 +++------
drivers/staging/iio/impedance-analyzer/ad5933.c | 3 +-
drivers/staging/iio/imu/adis16400_core.c | 3 +-
drivers/staging/iio/industrialio-core.c | 3 --
drivers/staging/iio/light/isl29018.c | 1 +
drivers/staging/iio/light/tsl2563.c | 5 +++-
drivers/staging/iio/light/tsl2583.c | 1 +
drivers/staging/iio/magnetometer/ak8975.c | 7 +++--
drivers/staging/iio/magnetometer/hmc5843.c | 4 ++-
drivers/staging/iio/meter/ade7753.c | 5 ++-
drivers/staging/iio/meter/ade7754.c | 3 +-
drivers/staging/iio/meter/ade7758_core.c | 5 ++-
drivers/staging/iio/meter/ade7759.c | 3 +-
drivers/staging/iio/meter/ade7854.c | 1 +
drivers/staging/iio/resolver/ad2s1200.c | 1 +
drivers/staging/iio/resolver/ad2s1210.c | 4 +-
drivers/staging/iio/resolver/ad2s90.c | 1 +
61 files changed, 149 insertions(+), 111 deletions(-)
--
1.7.7
next reply other threads:[~2011-10-14 13:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 13:46 Jonathan Cameron [this message]
2011-10-14 13:46 ` [PATCH 1/2] staging:iio: fix removal path to allow correct freeing Jonathan Cameron
2011-10-14 13:46 ` [PATCH 2/2] staging:iio:adc:max1363 incorrect allocation of available_scanmasks Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318600019-11809-1-git-send-email-jic23@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=greg@kroah.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).