From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Lars-Peter Clausen To: Jonathan Cameron CC: Michael Hennerich , , , , Lars-Peter Clausen Subject: [PATCH 1/4] staging:iio:dac:ad5791: Use correct DAC bit-size Date: Wed, 19 Oct 2011 14:23:47 +0200 Message-ID: <1319027030-9696-1-git-send-email-lars@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain List-ID: Commit c5b99396 ("staging:iio:dac:ad5791 chan spec conversion.") introduced a small bug, using storagebits instead of realbits throughout the driver, which causes the driver to work incorrectly. This patch fixes it. Signed-off-by: Lars-Peter Clausen --- drivers/staging/iio/dac/ad5791.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c index fbf446d..9a76c43 100644 --- a/drivers/staging/iio/dac/ad5791.c +++ b/drivers/staging/iio/dac/ad5791.c @@ -234,11 +234,11 @@ static int ad5791_read_raw(struct iio_dev *indio_dev, return ret; *val &= AD5791_DAC_MASK; *val >>= chan->scan_type.shift; - *val -= (1 << (chan->scan_type.storagebits - 1)); + *val -= (1 << (chan->scan_type.realbits - 1)); return IIO_VAL_INT; case (1 << IIO_CHAN_INFO_SCALE_SHARED): *val = 0; - *val2 = (st->vref_mv * 1000) >> chan->scan_type.storagebits; + *val2 = (st->vref_mv * 1000) >> chan->scan_type.realbits; return IIO_VAL_INT_PLUS_MICRO; default: return -EINVAL; @@ -257,8 +257,8 @@ static int ad5791_write_raw(struct iio_dev *indio_dev, switch (mask) { case 0: - val += (1 << (chan->scan_type.storagebits - 1)); - val &= AD5791_RES_MASK(chan->scan_type.storagebits); + val += (1 << (chan->scan_type.realbits - 1)); + val &= AD5791_RES_MASK(chan->scan_type.realbits); val <<= chan->scan_type.shift; return ad5791_spi_write(st->spi, chan->address, val); -- 1.7.6.3