From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Lars-Peter Clausen To: Greg Kroah-Hartman CC: Jonathan Cameron , Michael Hennerich , , , , , Lars-Peter Clausen Subject: [PATCH] staging:iio:dac:ad5686: Check for negative values Date: Wed, 19 Oct 2011 17:51:28 +0200 Message-ID: <1319039488-19810-1-git-send-email-lars@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain List-ID: Currently it is possible to write negative values to the ad5686's raw attribute. This will cause undefined behaviour, so reject negative values. Signed-off-by: Lars-Peter Clausen Acked-by: Jonathan Cameron --- drivers/staging/iio/dac/ad5686.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/iio/dac/ad5686.c b/drivers/staging/iio/dac/ad5686.c index 1d50dd1..48389e1 100644 --- a/drivers/staging/iio/dac/ad5686.c +++ b/drivers/staging/iio/dac/ad5686.c @@ -327,7 +327,7 @@ static int ad5686_write_raw(struct iio_dev *indio_dev, switch (mask) { case 0: - if (val > (1 << chan->scan_type.realbits)) + if (val > (1 << chan->scan_type.realbits) || val < 0) return -EINVAL; mutex_lock(&indio_dev->mlock); -- 1.7.6.3