linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] staging:iio: one more fix
@ 2011-10-24  9:49 Jonathan Cameron
  2011-10-24  9:49 ` [PATCH] staging:iio:core shared attrs do not work with modifier Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Jonathan Cameron @ 2011-10-24  9:49 UTC (permalink / raw)
  To: linux-iio; +Cc: Jonathan Cameron

Drat, missed this one in the last set.

Anyhow, relatively trivial.

Jonathan Cameron (1):
  staging:iio:core shared attrs do not work with modifier.

 drivers/staging/iio/industrialio-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

-- 
1.7.7

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] staging:iio:core shared attrs do not work with modifier.
  2011-10-24  9:49 [PATCH] staging:iio: one more fix Jonathan Cameron
@ 2011-10-24  9:49 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2011-10-24  9:49 UTC (permalink / raw)
  To: linux-iio; +Cc: Jonathan Cameron

The logic building the name had a small bug where
it did not verify if it was generic before applying the
modifier.

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
---
 drivers/staging/iio/industrialio-core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
index 326e967..555877d 100644
--- a/drivers/staging/iio/industrialio-core.c
+++ b/drivers/staging/iio/industrialio-core.c
@@ -408,7 +408,7 @@ int __iio_device_attr_init(struct device_attribute *dev_attr,
 	sysfs_attr_init(&dev_attr->attr);
 
 	/* Build up postfix of <extend_name>_<modifier>_postfix */
-	if (chan->modified) {
+	if (chan->modified && !generic) {
 		if (chan->extend_name)
 			full_postfix = kasprintf(GFP_KERNEL, "%s_%s_%s",
 						 iio_modifier_names[chan
-- 
1.7.7


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-10-24  9:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-24  9:49 [PATCH] staging:iio: one more fix Jonathan Cameron
2011-10-24  9:49 ` [PATCH] staging:iio:core shared attrs do not work with modifier Jonathan Cameron

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).