linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Michael Hennerich <michael.hennerich@analog.com>,
	<linux-iio@vger.kernel.org>,
	<device-drivers-devel@blackfin.uclinux.org>, <drivers@analog.com>,
	Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH v2 10/13] staging:iio:adc:max1363: Use new ringbuffer setup helper function
Date: Mon, 12 Dec 2011 11:43:02 +0100	[thread overview]
Message-ID: <1323686585-15181-10-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1323686585-15181-1-git-send-email-lars@metafoo.de>

Use the new ringbuffer setup helper function to allocate and register buffer and
pollfunc.

Acked-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 drivers/staging/iio/adc/max1363_core.c |    9 ------
 drivers/staging/iio/adc/max1363_ring.c |   43 ++-----------------------------
 2 files changed, 3 insertions(+), 49 deletions(-)

diff --git a/drivers/staging/iio/adc/max1363_core.c b/drivers/staging/iio/adc/max1363_core.c
index 1ce89ef..a14329e 100644
--- a/drivers/staging/iio/adc/max1363_core.c
+++ b/drivers/staging/iio/adc/max1363_core.c
@@ -1306,12 +1306,6 @@ static int __devinit max1363_probe(struct i2c_client *client,
 	if (ret)
 		goto error_free_available_scan_masks;
 
-	ret = iio_buffer_register(indio_dev,
-				  st->chip_info->channels,
-				  st->chip_info->num_channels);
-	if (ret)
-		goto error_cleanup_ring;
-
 	if (client->irq) {
 		ret = request_threaded_irq(st->client->irq,
 					   NULL,
@@ -1332,8 +1326,6 @@ static int __devinit max1363_probe(struct i2c_client *client,
 error_free_irq:
 	free_irq(st->client->irq, indio_dev);
 error_uninit_ring:
-	iio_buffer_unregister(indio_dev);
-error_cleanup_ring:
 	max1363_ring_cleanup(indio_dev);
 error_free_available_scan_masks:
 	kfree(indio_dev->available_scan_masks);
@@ -1356,7 +1348,6 @@ static int max1363_remove(struct i2c_client *client)
 	iio_device_unregister(indio_dev);
 	if (client->irq)
 		free_irq(st->client->irq, indio_dev);
-	iio_buffer_unregister(indio_dev);
 	max1363_ring_cleanup(indio_dev);
 	kfree(indio_dev->available_scan_masks);
 	if (!IS_ERR(reg)) {
diff --git a/drivers/staging/iio/adc/max1363_ring.c b/drivers/staging/iio/adc/max1363_ring.c
index d0a60a3..e38b923 100644
--- a/drivers/staging/iio/adc/max1363_ring.c
+++ b/drivers/staging/iio/adc/max1363_ring.c
@@ -89,50 +89,13 @@ done:
 	return IRQ_HANDLED;
 }
 
-static const struct iio_buffer_setup_ops max1363_ring_setup_ops = {
-	.postenable = &iio_triggered_buffer_postenable,
-	.preenable = &iio_sw_buffer_preenable,
-	.predisable = &iio_triggered_buffer_predisable,
-};
-
 int max1363_register_ring_funcs_and_init(struct iio_dev *indio_dev)
 {
-	struct max1363_state *st = iio_priv(indio_dev);
-	int ret = 0;
-
-	indio_dev->buffer = iio_sw_rb_allocate(indio_dev);
-	if (!indio_dev->buffer) {
-		ret = -ENOMEM;
-		goto error_ret;
-	}
-	indio_dev->pollfunc = iio_alloc_pollfunc(NULL,
-						 &max1363_trigger_handler,
-						 IRQF_ONESHOT,
-						 indio_dev,
-						 "%s_consumer%d",
-						 st->client->name,
-						 indio_dev->id);
-	if (indio_dev->pollfunc == NULL) {
-		ret = -ENOMEM;
-		goto error_deallocate_sw_rb;
-	}
-	/* Ring buffer functions - here trigger setup related */
-	indio_dev->setup_ops = &max1363_ring_setup_ops;
-
-	/* Flag that polled ring buffering is possible */
-	indio_dev->modes |= INDIO_BUFFER_TRIGGERED;
-
-	return 0;
-
-error_deallocate_sw_rb:
-	iio_sw_rb_free(indio_dev->buffer);
-error_ret:
-	return ret;
+	return iio_sw_rb_simple_setup(indio_dev, NULL,
+	    &max1363_trigger_handler, NULL);
 }
 
 void max1363_ring_cleanup(struct iio_dev *indio_dev)
 {
-	/* ensure that the trigger has been detached */
-	iio_dealloc_pollfunc(indio_dev->pollfunc);
-	iio_sw_rb_free(indio_dev->buffer);
+	iio_sw_rb_simple_cleanup(indio_dev);
 }
-- 
1.7.7.3

  parent reply	other threads:[~2011-12-12 10:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12 10:42 [PATCH v2 01/13] staging:iio:ring_sw: Add helper function for initializing simple setups Lars-Peter Clausen
2011-12-12 10:42 ` [PATCH v2 02/13] staging:iio:accel:adis16201: Use new ringbuffer setup helper function Lars-Peter Clausen
2011-12-12 10:42 ` [PATCH v2 03/13] staging:iio:adc:ad7192: " Lars-Peter Clausen
2011-12-12 10:42 ` [PATCH v2 04/13] staging:iio:adc:ad7298: " Lars-Peter Clausen
2011-12-12 10:42 ` [PATCH v2 05/13] staging:iio:adc:ad7476: " Lars-Peter Clausen
2011-12-12 10:42 ` [PATCH v2 06/13] staging:iio:adc:ad7606: " Lars-Peter Clausen
2011-12-12 10:42 ` [PATCH v2 07/13] staging:iio:adc:ad7793: " Lars-Peter Clausen
2011-12-12 10:43 ` [PATCH v2 08/13] staging:iio:adc:ad7887: " Lars-Peter Clausen
2011-12-12 10:43 ` [PATCH v2 09/13] staging:iio:adc:ad799x: " Lars-Peter Clausen
2011-12-12 10:43 ` Lars-Peter Clausen [this message]
2011-12-12 10:43 ` [PATCH v2 11/13] staging:iio:gyro:adis16260: " Lars-Peter Clausen
2011-12-12 10:43 ` [PATCH v2 12/13] staging:iio:imu:adis16400: " Lars-Peter Clausen
2011-12-12 10:43 ` [PATCH v2 13/13] staging:iio:meter:ade7758: " Lars-Peter Clausen
2011-12-13 14:55 ` [PATCH v2 01/13] staging:iio:ring_sw: Add helper function for initializing simple setups Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323686585-15181-10-git-send-email-lars@metafoo.de \
    --to=lars@metafoo.de \
    --cc=device-drivers-devel@blackfin.uclinux.org \
    --cc=drivers@analog.com \
    --cc=jic23@cam.ac.uk \
    --cc=linux-iio@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).