From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: Jonathan Cameron <jic23@kernel.org>
Subject: [PATCH 2/5] staging:iio:accel:lis3l02dq add symmetry to check for presence of trigger.
Date: Sat, 3 Mar 2012 11:39:12 +0000 [thread overview]
Message-ID: <1330774755-18031-3-git-send-email-jic23@kernel.org> (raw)
In-Reply-To: <1330774755-18031-1-git-send-email-jic23@kernel.org>
Checking indio_dev->modes is uggly and not symmetric with the conditions
on whether triggers are allowed in the first place.
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---
drivers/staging/iio/accel/lis3l02dq_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/accel/lis3l02dq_core.c b/drivers/staging/iio/accel/lis3l02dq_core.c
index 376da51..bcf4712 100644
--- a/drivers/staging/iio/accel/lis3l02dq_core.c
+++ b/drivers/staging/iio/accel/lis3l02dq_core.c
@@ -724,7 +724,7 @@ static int __devinit lis3l02dq_probe(struct spi_device *spi)
return 0;
error_remove_trigger:
- if (indio_dev->modes & INDIO_BUFFER_TRIGGERED)
+ if (spi->irq && gpio_is_valid(irq_to_gpio(spi->irq)))
lis3l02dq_remove_trigger(indio_dev);
error_free_interrupt:
if (spi->irq && gpio_is_valid(irq_to_gpio(spi->irq)) > 0)
--
1.7.9.2
next prev parent reply other threads:[~2012-03-03 11:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 11:39 [PATCH 0/5] IIO mixed bag of trivial + fixes Jonathan Cameron
2012-03-03 11:39 ` [PATCH 1/5] staging:iio fill in some missing docs Jonathan Cameron
2012-03-03 11:39 ` Jonathan Cameron [this message]
2012-03-03 11:39 ` [PATCH 3/5] staging:iio: use spi->irq valid rather than querying available modes Jonathan Cameron
2012-03-03 11:39 ` [PATCH 4/5] staging:iio:adc:max1363 fix missing update_scan_mask callback Jonathan Cameron
2012-03-03 11:39 ` [PATCH 5/5] staging:iio:iio_core.h make less dependent on other included headers Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330774755-18031-3-git-send-email-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).