* [PATCH 0/4] IIO: Another set of buglets plus cleanups.
@ 2012-04-13 9:24 Jonathan Cameron
2012-04-13 9:24 ` [PATCH 1/4] staging:iio:light:tsl2563 channel spec buglet / always reading same adc Jonathan Cameron
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-04-13 9:24 UTC (permalink / raw)
To: gregkh; +Cc: linux-iio, Jonathan Cameron
Hi Greg,
A fairly trivial set that no one has reported any problems with.
Only difference in here from version sent to list was an accidentally
included binary file pointed out by Maxime Ripard.
Thanks,
Jonathan
Jonathan Cameron (4):
staging:iio:light:tsl2563 channel spec buglet / always reading same
adc.
staging:iio:Documentation: Fix a cut and paste error.
staging:iio:iio_core.h make less dependent on other included headers
staging:iio: chan_spec - take extend_name constant.
drivers/staging/iio/Documentation/sysfs-bus-iio | 8 ++++----
drivers/staging/iio/iio.h | 2 +-
drivers/staging/iio/iio_core.h | 6 ++++++
drivers/staging/iio/light/tsl2563.c | 3 ++-
4 files changed, 13 insertions(+), 6 deletions(-)
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/4] staging:iio:light:tsl2563 channel spec buglet / always reading same adc.
2012-04-13 9:24 [PATCH 0/4] IIO: Another set of buglets plus cleanups Jonathan Cameron
@ 2012-04-13 9:24 ` Jonathan Cameron
2012-04-13 9:24 ` [PATCH 2/4] staging:iio:Documentation: Fix a cut and paste error Jonathan Cameron
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-04-13 9:24 UTC (permalink / raw)
To: gregkh; +Cc: linux-iio, Jonathan Cameron
The IIO_LIGHT channel was not marked as being a processed_val despite
clearly being in lux.
The IIO_INTENSITY channel reads were dependent on channel and that isn't
specified for either adc (as they now use modifiers). Hence use the
modifier instead.
Reported-by: Jon Brenner <jbrenner@taosinc.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---
drivers/staging/iio/light/tsl2563.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/iio/light/tsl2563.c b/drivers/staging/iio/light/tsl2563.c
index 546c95a..beb51d7 100644
--- a/drivers/staging/iio/light/tsl2563.c
+++ b/drivers/staging/iio/light/tsl2563.c
@@ -465,7 +465,7 @@ static int tsl2563_write_raw(struct iio_dev *indio_dev,
{
struct tsl2563_chip *chip = iio_priv(indio_dev);
- if (chan->channel == 0)
+ if (chan->channel == IIO_MOD_LIGHT_BOTH)
chip->calib0 = calib_from_sysfs(val);
else
chip->calib1 = calib_from_sysfs(val);
@@ -534,6 +534,7 @@ static const struct iio_chan_spec tsl2563_channels[] = {
{
.type = IIO_LIGHT,
.indexed = 1,
+ .processed_val = 1,
.channel = 0,
}, {
.type = IIO_INTENSITY,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/4] staging:iio:Documentation: Fix a cut and paste error.
2012-04-13 9:24 [PATCH 0/4] IIO: Another set of buglets plus cleanups Jonathan Cameron
2012-04-13 9:24 ` [PATCH 1/4] staging:iio:light:tsl2563 channel spec buglet / always reading same adc Jonathan Cameron
@ 2012-04-13 9:24 ` Jonathan Cameron
2012-04-13 9:24 ` [PATCH 3/4] staging:iio:iio_core.h make less dependent on other included headers Jonathan Cameron
2012-04-13 9:24 ` [PATCH 4/4] staging:iio: chan_spec - take extend_name constant Jonathan Cameron
3 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-04-13 9:24 UTC (permalink / raw)
To: gregkh; +Cc: linux-iio, Jonathan Cameron
falling is repeated in some entries instead of 1x falling and 1x rising
for the entry.
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---
drivers/staging/iio/Documentation/sysfs-bus-iio | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/iio/Documentation/sysfs-bus-iio b/drivers/staging/iio/Documentation/sysfs-bus-iio
index 46a995d..ca12784 100644
--- a/drivers/staging/iio/Documentation/sysfs-bus-iio
+++ b/drivers/staging/iio/Documentation/sysfs-bus-iio
@@ -453,9 +453,9 @@ What: /sys/.../events/in_magn_z_raw_thresh_rising_value
What: /sys/.../events/in_magn_z_raw_thresh_falling_value
What: /sys/.../events/in_voltageY_supply_raw_thresh_rising_value
What: /sys/.../events/in_voltageY_supply_raw_thresh_falling_value
+What: /sys/.../events/in_voltageY_raw_thresh_rising_value
What: /sys/.../events/in_voltageY_raw_thresh_falling_value
-What: /sys/.../events/in_voltageY_raw_thresh_falling_value
-What: /sys/.../events/in_tempY_raw_thresh_falling_value
+What: /sys/.../events/in_tempY_raw_thresh_rising_value
What: /sys/.../events/in_tempY_raw_thresh_falling_value
KernelVersion: 2.6.37
Contact: linux-iio@vger.kernel.org
@@ -490,9 +490,9 @@ What: /sys/.../events/in_magn_z_raw_roc_rising_value
What: /sys/.../events/in_magn_z_raw_roc_falling_value
What: /sys/.../events/in_voltageY_supply_raw_roc_rising_value
What: /sys/.../events/in_voltageY_supply_raw_roc_falling_value
+What: /sys/.../events/in_voltageY_raw_roc_rising_value
What: /sys/.../events/in_voltageY_raw_roc_falling_value
-What: /sys/.../events/in_voltageY_raw_roc_falling_value
-What: /sys/.../events/in_tempY_raw_roc_falling_value
+What: /sys/.../events/in_tempY_raw_roc_rising_value
What: /sys/.../events/in_tempY_raw_roc_falling_value
KernelVersion: 2.6.37
Contact: linux-iio@vger.kernel.org
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/4] staging:iio:iio_core.h make less dependent on other included headers
2012-04-13 9:24 [PATCH 0/4] IIO: Another set of buglets plus cleanups Jonathan Cameron
2012-04-13 9:24 ` [PATCH 1/4] staging:iio:light:tsl2563 channel spec buglet / always reading same adc Jonathan Cameron
2012-04-13 9:24 ` [PATCH 2/4] staging:iio:Documentation: Fix a cut and paste error Jonathan Cameron
@ 2012-04-13 9:24 ` Jonathan Cameron
2012-04-13 9:24 ` [PATCH 4/4] staging:iio: chan_spec - take extend_name constant Jonathan Cameron
3 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-04-13 9:24 UTC (permalink / raw)
To: gregkh; +Cc: linux-iio, Jonathan Cameron
There are a lot of pointers to structures used in here that are not
declared unless a particular header is included first. Deal with
the IIO specific ones by putting in forward declarations and the
other ones by including kernel.h and device.h.
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---
drivers/staging/iio/iio_core.h | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/iio/iio_core.h b/drivers/staging/iio/iio_core.h
index c9dfcba..f652e6a 100644
--- a/drivers/staging/iio/iio_core.h
+++ b/drivers/staging/iio/iio_core.h
@@ -12,6 +12,12 @@
#ifndef _IIO_CORE_H_
#define _IIO_CORE_H_
+#include <linux/kernel.h>
+#include <linux/device.h>
+
+struct iio_chan_spec;
+struct iio_dev;
+
int __iio_add_chan_devattr(const char *postfix,
struct iio_chan_spec const *chan,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] staging:iio: chan_spec - take extend_name constant.
2012-04-13 9:24 [PATCH 0/4] IIO: Another set of buglets plus cleanups Jonathan Cameron
` (2 preceding siblings ...)
2012-04-13 9:24 ` [PATCH 3/4] staging:iio:iio_core.h make less dependent on other included headers Jonathan Cameron
@ 2012-04-13 9:24 ` Jonathan Cameron
3 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-04-13 9:24 UTC (permalink / raw)
To: gregkh; +Cc: linux-iio, Jonathan Cameron
I can't envision a case where this is not constant and we
don't seem to have any in tree, so lets clear up this loose
end.
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---
drivers/staging/iio/iio.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/staging/iio/iio.h b/drivers/staging/iio/iio.h
index 833a849..4824812 100644
--- a/drivers/staging/iio/iio.h
+++ b/drivers/staging/iio/iio.h
@@ -164,7 +164,7 @@ struct iio_chan_spec {
long info_mask;
long event_mask;
const struct iio_chan_spec_ext_info *ext_info;
- char *extend_name;
+ const char *extend_name;
const char *datasheet_name;
unsigned processed_val:1;
unsigned modified:1;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 0/4] IIO: Another set of buglets plus cleanups.
@ 2012-04-10 20:17 Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-04-10 20:17 UTC (permalink / raw)
To: linux-iio; +Cc: jbrenner, Jonathan Cameron
Nothing links these really but seems silly to send them as 4 series.
I'll try and be a bit quicker sending these on to Greg if no one
has any issue with them. Reviews always welcome of course!
Jonathan Cameron (4):
staging:iio:light:tsl2563 channel spec buglet / always reading same
adc.
staging:iio:Documentation: Fix a cut and paste error.
staging:iio:iio_core.h make less dependent on other included headers
staging:iio: chan_spec - take extend_name constant.
drivers/staging/iio/Documentation/gb | Bin 0 -> 33746 bytes
drivers/staging/iio/Documentation/sysfs-bus-iio | 8 ++++----
drivers/staging/iio/iio.h | 2 +-
drivers/staging/iio/iio_core.h | 6 ++++++
drivers/staging/iio/light/tsl2563.c | 3 ++-
5 files changed, 13 insertions(+), 6 deletions(-)
create mode 100755 drivers/staging/iio/Documentation/gb
--
1.7.9.4
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-04-13 9:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-13 9:24 [PATCH 0/4] IIO: Another set of buglets plus cleanups Jonathan Cameron
2012-04-13 9:24 ` [PATCH 1/4] staging:iio:light:tsl2563 channel spec buglet / always reading same adc Jonathan Cameron
2012-04-13 9:24 ` [PATCH 2/4] staging:iio:Documentation: Fix a cut and paste error Jonathan Cameron
2012-04-13 9:24 ` [PATCH 3/4] staging:iio:iio_core.h make less dependent on other included headers Jonathan Cameron
2012-04-13 9:24 ` [PATCH 4/4] staging:iio: chan_spec - take extend_name constant Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2012-04-10 20:17 [PATCH 0/4] IIO: Another set of buglets plus cleanups Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).