* [PATCH] IIO: industrialio-core: Use simple_open
@ 2012-05-03 1:50 Axel Lin
2012-05-03 6:49 ` Hennerich, Michael
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2012-05-03 1:50 UTC (permalink / raw)
To: linux-kernel; +Cc: Jonathan Cameron, linux-iio, Greg Kroah-Hartman
Use simple_open to replace iio_debugfs_open.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/iio/industrialio-core.c | 10 +---------
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index 72e33b8..52aa44a 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -152,14 +152,6 @@ static void __exit iio_exit(void)
}
#if defined(CONFIG_DEBUG_FS)
-static int iio_debugfs_open(struct inode *inode, struct file *file)
-{
- if (inode->i_private)
- file->private_data = inode->i_private;
-
- return 0;
-}
-
static ssize_t iio_debugfs_read_reg(struct file *file, char __user *userbuf,
size_t count, loff_t *ppos)
{
@@ -218,7 +210,7 @@ static ssize_t iio_debugfs_write_reg(struct file *file,
}
static const struct file_operations iio_debugfs_reg_fops = {
- .open = iio_debugfs_open,
+ .open = simple_open,
.read = iio_debugfs_read_reg,
.write = iio_debugfs_write_reg,
};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] IIO: industrialio-core: Use simple_open
2012-05-03 1:50 [PATCH] IIO: industrialio-core: Use simple_open Axel Lin
@ 2012-05-03 6:49 ` Hennerich, Michael
2012-05-03 7:27 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Hennerich, Michael @ 2012-05-03 6:49 UTC (permalink / raw)
To: Axel Lin, linux-kernel@vger.kernel.org
Cc: Jonathan Cameron, linux-iio@vger.kernel.org, Greg Kroah-Hartman
QXhlbCBMaW4gd3JvdGUgb24gMjAxMi0wNS0wMzoNCj4gVXNlIHNpbXBsZV9vcGVuIHRvIHJlcGxh
Y2UgaWlvX2RlYnVnZnNfb3Blbi4NCj4NCj4gU2lnbmVkLW9mZi1ieTogQXhlbCBMaW4gPGF4ZWwu
bGluQGdtYWlsLmNvbT4NCkFja2VkLWJ5OiBNaWNoYWVsIEhlbm5lcmljaCA8bWljaGFlbC5oZW5u
ZXJpY2hAYW5hbG9nLmNvbT4NCj4gLS0tDQo+ICBkcml2ZXJzL2lpby9pbmR1c3RyaWFsaW8tY29y
ZS5jIHwgICAxMCArLS0tLS0tLS0tDQo+ICAxIGZpbGVzIGNoYW5nZWQsIDEgaW5zZXJ0aW9ucygr
KSwgOSBkZWxldGlvbnMoLSkNCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaWlvL2luZHVzdHJpYWxp
by1jb3JlLmMNCj4gYi9kcml2ZXJzL2lpby9pbmR1c3RyaWFsaW8tY29yZS5jIGluZGV4IDcyZTMz
YjguLjUyYWE0NGEgMTAwNjQ0IC0tLQ0KPiBhL2RyaXZlcnMvaWlvL2luZHVzdHJpYWxpby1jb3Jl
LmMgKysrIGIvZHJpdmVycy9paW8vaW5kdXN0cmlhbGlvLWNvcmUuYw0KPiBAQCAtMTUyLDE0ICsx
NTIsNiBAQCBzdGF0aWMgdm9pZCBfX2V4aXQgaWlvX2V4aXQodm9pZCkNCj4gIH0NCj4NCj4gICNp
ZiBkZWZpbmVkKENPTkZJR19ERUJVR19GUykNCj4gLXN0YXRpYyBpbnQgaWlvX2RlYnVnZnNfb3Bl
bihzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzdHJ1Y3QgZmlsZSAqZmlsZSkgLXsNCj4gLSAgICAgaWYg
KGlub2RlLT5pX3ByaXZhdGUpIC0gICAgICAgICBmaWxlLT5wcml2YXRlX2RhdGEgPSBpbm9kZS0+
aV9wcml2YXRlOyAtDQo+IC0gICAgIHJldHVybiAwOyAtfSAtDQo+ICBzdGF0aWMgc3NpemVfdCBp
aW9fZGVidWdmc19yZWFkX3JlZyhzdHJ1Y3QgZmlsZSAqZmlsZSwgY2hhciBfX3VzZXINCj4gICp1
c2VyYnVmLCAgICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZV90IGNvdW50LCBsb2ZmX3QgKnBw
b3MpIHsNCj4gQEAgLTIxOCw3ICsyMTAsNyBAQCBzdGF0aWMgc3NpemVfdCBpaW9fZGVidWdmc193
cml0ZV9yZWcoc3RydWN0IGZpbGUNCj4gKmZpbGUsDQo+ICB9DQo+DQo+ICBzdGF0aWMgY29uc3Qg
c3RydWN0IGZpbGVfb3BlcmF0aW9ucyBpaW9fZGVidWdmc19yZWdfZm9wcyA9IHsNCj4gLSAgICAg
Lm9wZW4gPSBpaW9fZGVidWdmc19vcGVuLA0KPiArICAgICAub3BlbiA9IHNpbXBsZV9vcGVuLA0K
PiAgICAgICAucmVhZCA9IGlpb19kZWJ1Z2ZzX3JlYWRfcmVnLA0KPiAgICAgICAud3JpdGUgPSBp
aW9fZGVidWdmc193cml0ZV9yZWcsDQo+ICB9Ow0KDQpHcmVldGluZ3MsDQpNaWNoYWVsDQoNCi0t
DQpBbmFsb2cgRGV2aWNlcyBHbWJIICAgICAgV2lsaGVsbS1XYWdlbmZlbGQtU3RyLiA2ICAgICAg
ODA4MDcgTXVlbmNoZW4NClNpdHogZGVyIEdlc2VsbHNjaGFmdDogTXVlbmNoZW47IFJlZ2lzdGVy
Z2VyaWNodDogTXVlbmNoZW4gSFJCIDQwMzY4Ow0KR2VzY2hhZWZ0c2Z1ZWhyZXI6RHIuQ2Fyc3Rl
biBTdWNrcm93LCBUaG9tYXMgV2Vzc2VsLCBXaWxsaWFtIEEuIE1hcnRpbiwgTWFyZ2FyZXQgU2Vp
Zg0KDQoNCg==
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IIO: industrialio-core: Use simple_open
2012-05-03 6:49 ` Hennerich, Michael
@ 2012-05-03 7:27 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2012-05-03 7:27 UTC (permalink / raw)
To: Hennerich, Michael
Cc: Axel Lin, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
Greg Kroah-Hartman
On 5/3/2012 7:49 AM, Hennerich, Michael wrote:
> Axel Lin wrote on 2012-05-03:
>> Use simple_open to replace iio_debugfs_open.
>>
>> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> Acked-by: Michael Hennerich<michael.hennerich@analog.com>
Acked-by: Jonathan Cameron <jic23@kernel.org>
>> ---
>> drivers/iio/industrialio-core.c | 10 +---------
>> 1 files changed, 1 insertions(+), 9 deletions(-)
>> diff --git a/drivers/iio/industrialio-core.c
>> b/drivers/iio/industrialio-core.c index 72e33b8..52aa44a 100644 ---
>> a/drivers/iio/industrialio-core.c +++ b/drivers/iio/industrialio-core.c
>> @@ -152,14 +152,6 @@ static void __exit iio_exit(void)
>> }
>>
>> #if defined(CONFIG_DEBUG_FS)
>> -static int iio_debugfs_open(struct inode *inode, struct file *file) -{
>> - if (inode->i_private) - file->private_data = inode->i_private; -
>> - return 0; -} -
>> static ssize_t iio_debugfs_read_reg(struct file *file, char __user
>> *userbuf, size_t count, loff_t *ppos) {
>> @@ -218,7 +210,7 @@ static ssize_t iio_debugfs_write_reg(struct file
>> *file,
>> }
>>
>> static const struct file_operations iio_debugfs_reg_fops = {
>> - .open = iio_debugfs_open,
>> + .open = simple_open,
>> .read = iio_debugfs_read_reg,
>> .write = iio_debugfs_write_reg,
>> };
> Greetings,
> Michael
>
> --
> Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
> Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
> Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-03 7:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-03 1:50 [PATCH] IIO: industrialio-core: Use simple_open Axel Lin
2012-05-03 6:49 ` Hennerich, Michael
2012-05-03 7:27 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).