* [PATCH] staging:iio:dummy: Remove outdated comment
@ 2012-05-11 13:12 Lars-Peter Clausen
0 siblings, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2012-05-11 13:12 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Jonathan Cameron, devel, linux-iio, Lars-Peter Clausen
iio_device_free has to be called regardless of whether the device has been
registered or not when freeing it.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
---
drivers/staging/iio/iio_simple_dummy.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_simple_dummy.c
index 3b4513c..3104119 100644
--- a/drivers/staging/iio/iio_simple_dummy.c
+++ b/drivers/staging/iio/iio_simple_dummy.c
@@ -470,8 +470,6 @@ error_unconfigure_buffer:
error_unregister_events:
iio_simple_dummy_events_unregister(indio_dev);
error_free_device:
- /* Note free device should only be called, before registration
- * has succeeded. */
iio_device_free(indio_dev);
error_ret:
return ret;
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] staging:iio:dummy: Remove outdated comment
@ 2012-05-11 12:04 Lars-Peter Clausen
2012-05-11 12:27 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Peter Clausen @ 2012-05-11 12:04 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Lars-Peter Clausen
iio_device_free has to be called regardless of whether the device has been
registered or not when freeing it.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/staging/iio/iio_simple_dummy.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_simple_dummy.c
index 3b4513c..3104119 100644
--- a/drivers/staging/iio/iio_simple_dummy.c
+++ b/drivers/staging/iio/iio_simple_dummy.c
@@ -470,8 +470,6 @@ error_unconfigure_buffer:
error_unregister_events:
iio_simple_dummy_events_unregister(indio_dev);
error_free_device:
- /* Note free device should only be called, before registration
- * has succeeded. */
iio_device_free(indio_dev);
error_ret:
return ret;
--
1.7.10
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:iio:dummy: Remove outdated comment
2012-05-11 12:04 Lars-Peter Clausen
@ 2012-05-11 12:27 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2012-05-11 12:27 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-iio
On 5/11/2012 1:04 PM, Lars-Peter Clausen wrote:
> iio_device_free has to be called regardless of whether the device has been
> registered or not when freeing it.
Good spot,
>
> Signed-off-by: Lars-Peter Clausen<lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/staging/iio/iio_simple_dummy.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/iio/iio_simple_dummy.c b/drivers/staging/iio/iio_simple_dummy.c
> index 3b4513c..3104119 100644
> --- a/drivers/staging/iio/iio_simple_dummy.c
> +++ b/drivers/staging/iio/iio_simple_dummy.c
> @@ -470,8 +470,6 @@ error_unconfigure_buffer:
> error_unregister_events:
> iio_simple_dummy_events_unregister(indio_dev);
> error_free_device:
> - /* Note free device should only be called, before registration
> - * has succeeded. */
> iio_device_free(indio_dev);
> error_ret:
> return ret;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-11 13:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-11 13:12 [PATCH] staging:iio:dummy: Remove outdated comment Lars-Peter Clausen
-- strict thread matches above, loose matches on Subject: below --
2012-05-11 12:04 Lars-Peter Clausen
2012-05-11 12:27 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).