* [PATCH 1/3] staging:iio:dac:ad5504: Use strtobool for boolean values
@ 2012-05-15 7:52 Lars-Peter Clausen
2012-05-15 7:52 ` [PATCH 2/3] staging:iio:dac:ad5624r: " Lars-Peter Clausen
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Lars-Peter Clausen @ 2012-05-15 7:52 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Lars-Peter Clausen
Use strtobool for parsing the powerdown value instead of strict_strtol, since
the powerdown attribute is a boolean value.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/staging/iio/dac/ad5504.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/iio/dac/ad5504.c b/drivers/staging/iio/dac/ad5504.c
index 25a04d3..6ccf178 100644
--- a/drivers/staging/iio/dac/ad5504.c
+++ b/drivers/staging/iio/dac/ad5504.c
@@ -147,20 +147,18 @@ static ssize_t ad5504_write_dac_powerdown(struct iio_dev *indio_dev,
uintptr_t private, const struct iio_chan_spec *chan, const char *buf,
size_t len)
{
- long readin;
+ bool pwr_down;
int ret;
struct ad5504_state *st = iio_priv(indio_dev);
- ret = strict_strtol(buf, 10, &readin);
+ ret = strtobool(buf, &pwr_down);
if (ret)
return ret;
- if (readin == 0)
+ if (pwr_down)
st->pwr_down_mask |= (1 << chan->channel);
- else if (readin == 1)
- st->pwr_down_mask &= ~(1 << chan->channel);
else
- ret = -EINVAL;
+ st->pwr_down_mask &= ~(1 << chan->channel);
ret = ad5504_spi_write(st->spi, AD5504_ADDR_CTRL,
AD5504_DAC_PWRDWN_MODE(st->pwr_down_mode) |
--
1.7.10
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] staging:iio:dac:ad5624r: Use strtobool for boolean values
2012-05-15 7:52 [PATCH 1/3] staging:iio:dac:ad5504: Use strtobool for boolean values Lars-Peter Clausen
@ 2012-05-15 7:52 ` Lars-Peter Clausen
2012-05-15 7:54 ` Jonathan Cameron
2012-05-15 7:52 ` [PATCH 3/3] staging:iio:dac:ad5791: " Lars-Peter Clausen
2012-05-15 7:54 ` [PATCH 1/3] staging:iio:dac:ad5504: " Jonathan Cameron
2 siblings, 1 reply; 6+ messages in thread
From: Lars-Peter Clausen @ 2012-05-15 7:52 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Lars-Peter Clausen
Use strtobool for parsing the powerdown value instead of strict_strtol, since
the powerdown attribute is a boolean value.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/staging/iio/dac/ad5624r_spi.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/iio/dac/ad5624r_spi.c b/drivers/staging/iio/dac/ad5624r_spi.c
index 7524f96..6a7d6a4 100644
--- a/drivers/staging/iio/dac/ad5624r_spi.c
+++ b/drivers/staging/iio/dac/ad5624r_spi.c
@@ -132,20 +132,18 @@ static ssize_t ad5624r_write_dac_powerdown(struct iio_dev *indio_dev,
uintptr_t private, const struct iio_chan_spec *chan, const char *buf,
size_t len)
{
- long readin;
+ bool pwr_down;
int ret;
struct ad5624r_state *st = iio_priv(indio_dev);
- ret = strict_strtol(buf, 10, &readin);
+ ret = strtobool(buf, &pwr_down);
if (ret)
return ret;
- if (readin == 1)
+ if (pwr_down)
st->pwr_down_mask |= (1 << chan->channel);
- else if (!readin)
- st->pwr_down_mask &= ~(1 << chan->channel);
else
- ret = -EINVAL;
+ st->pwr_down_mask &= ~(1 << chan->channel);
ret = ad5624r_spi_write(st->us, AD5624R_CMD_POWERDOWN_DAC, 0,
(st->pwr_down_mode << 4) |
--
1.7.10
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] staging:iio:dac:ad5791: Use strtobool for boolean values
2012-05-15 7:52 [PATCH 1/3] staging:iio:dac:ad5504: Use strtobool for boolean values Lars-Peter Clausen
2012-05-15 7:52 ` [PATCH 2/3] staging:iio:dac:ad5624r: " Lars-Peter Clausen
@ 2012-05-15 7:52 ` Lars-Peter Clausen
2012-05-15 7:54 ` Jonathan Cameron
2012-05-15 7:54 ` [PATCH 1/3] staging:iio:dac:ad5504: " Jonathan Cameron
2 siblings, 1 reply; 6+ messages in thread
From: Lars-Peter Clausen @ 2012-05-15 7:52 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Lars-Peter Clausen
Use strtobool for parsing the powerdown value instead of strict_strtol, since
the powerdown attribute is a boolean value.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/staging/iio/dac/ad5791.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c
index 4e955ed..82b51a7 100644
--- a/drivers/staging/iio/dac/ad5791.c
+++ b/drivers/staging/iio/dac/ad5791.c
@@ -114,25 +114,23 @@ static ssize_t ad5791_write_dac_powerdown(struct iio_dev *indio_dev,
uintptr_t private, const struct iio_chan_spec *chan, const char *buf,
size_t len)
{
- long readin;
+ bool pwr_down;
int ret;
struct ad5791_state *st = iio_priv(indio_dev);
- ret = strict_strtol(buf, 10, &readin);
+ ret = strtobool(buf, &pwr_down);
if (ret)
return ret;
- if (readin == 0) {
- st->pwr_down = false;
+ if (!pwr_down) {
st->ctrl &= ~(AD5791_CTRL_OPGND | AD5791_CTRL_DACTRI);
- } else if (readin == 1) {
- st->pwr_down = true;
+ } else {
if (st->pwr_down_mode == AD5791_DAC_PWRDN_6K)
st->ctrl |= AD5791_CTRL_OPGND;
else if (st->pwr_down_mode == AD5791_DAC_PWRDN_3STATE)
st->ctrl |= AD5791_CTRL_DACTRI;
- } else
- ret = -EINVAL;
+ }
+ st->pwr_down = pwr_down;
ret = ad5791_spi_write(st->spi, AD5791_ADDR_CTRL, st->ctrl);
--
1.7.10
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] staging:iio:dac:ad5504: Use strtobool for boolean values
2012-05-15 7:52 [PATCH 1/3] staging:iio:dac:ad5504: Use strtobool for boolean values Lars-Peter Clausen
2012-05-15 7:52 ` [PATCH 2/3] staging:iio:dac:ad5624r: " Lars-Peter Clausen
2012-05-15 7:52 ` [PATCH 3/3] staging:iio:dac:ad5791: " Lars-Peter Clausen
@ 2012-05-15 7:54 ` Jonathan Cameron
2 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-05-15 7:54 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-iio
On 5/15/2012 8:52 AM, Lars-Peter Clausen wrote:
> Use strtobool for parsing the powerdown value instead of strict_strtol, since
> the powerdown attribute is a boolean value.
>
> Signed-off-by: Lars-Peter Clausen<lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/staging/iio/dac/ad5504.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/dac/ad5504.c b/drivers/staging/iio/dac/ad5504.c
> index 25a04d3..6ccf178 100644
> --- a/drivers/staging/iio/dac/ad5504.c
> +++ b/drivers/staging/iio/dac/ad5504.c
> @@ -147,20 +147,18 @@ static ssize_t ad5504_write_dac_powerdown(struct iio_dev *indio_dev,
> uintptr_t private, const struct iio_chan_spec *chan, const char *buf,
> size_t len)
> {
> - long readin;
> + bool pwr_down;
> int ret;
> struct ad5504_state *st = iio_priv(indio_dev);
>
> - ret = strict_strtol(buf, 10,&readin);
> + ret = strtobool(buf,&pwr_down);
> if (ret)
> return ret;
>
> - if (readin == 0)
> + if (pwr_down)
> st->pwr_down_mask |= (1<< chan->channel);
> - else if (readin == 1)
> - st->pwr_down_mask&= ~(1<< chan->channel);
> else
> - ret = -EINVAL;
> + st->pwr_down_mask&= ~(1<< chan->channel);
>
> ret = ad5504_spi_write(st->spi, AD5504_ADDR_CTRL,
> AD5504_DAC_PWRDWN_MODE(st->pwr_down_mode) |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] staging:iio:dac:ad5624r: Use strtobool for boolean values
2012-05-15 7:52 ` [PATCH 2/3] staging:iio:dac:ad5624r: " Lars-Peter Clausen
@ 2012-05-15 7:54 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-05-15 7:54 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-iio
On 5/15/2012 8:52 AM, Lars-Peter Clausen wrote:
> Use strtobool for parsing the powerdown value instead of strict_strtol, since
> the powerdown attribute is a boolean value.
>
> Signed-off-by: Lars-Peter Clausen<lars@metafoo.de>
Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/staging/iio/dac/ad5624r_spi.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/iio/dac/ad5624r_spi.c b/drivers/staging/iio/dac/ad5624r_spi.c
> index 7524f96..6a7d6a4 100644
> --- a/drivers/staging/iio/dac/ad5624r_spi.c
> +++ b/drivers/staging/iio/dac/ad5624r_spi.c
> @@ -132,20 +132,18 @@ static ssize_t ad5624r_write_dac_powerdown(struct iio_dev *indio_dev,
> uintptr_t private, const struct iio_chan_spec *chan, const char *buf,
> size_t len)
> {
> - long readin;
> + bool pwr_down;
> int ret;
> struct ad5624r_state *st = iio_priv(indio_dev);
>
> - ret = strict_strtol(buf, 10,&readin);
> + ret = strtobool(buf,&pwr_down);
> if (ret)
> return ret;
>
> - if (readin == 1)
> + if (pwr_down)
> st->pwr_down_mask |= (1<< chan->channel);
> - else if (!readin)
> - st->pwr_down_mask&= ~(1<< chan->channel);
> else
> - ret = -EINVAL;
> + st->pwr_down_mask&= ~(1<< chan->channel);
>
> ret = ad5624r_spi_write(st->us, AD5624R_CMD_POWERDOWN_DAC, 0,
> (st->pwr_down_mode<< 4) |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] staging:iio:dac:ad5791: Use strtobool for boolean values
2012-05-15 7:52 ` [PATCH 3/3] staging:iio:dac:ad5791: " Lars-Peter Clausen
@ 2012-05-15 7:54 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2012-05-15 7:54 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: linux-iio
On 5/15/2012 8:52 AM, Lars-Peter Clausen wrote:
> Use strtobool for parsing the powerdown value instead of strict_strtol, since
> the powerdown attribute is a boolean value.
>
> Signed-off-by: Lars-Peter Clausen<lars@metafoo.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
> ---
> drivers/staging/iio/dac/ad5791.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/iio/dac/ad5791.c b/drivers/staging/iio/dac/ad5791.c
> index 4e955ed..82b51a7 100644
> --- a/drivers/staging/iio/dac/ad5791.c
> +++ b/drivers/staging/iio/dac/ad5791.c
> @@ -114,25 +114,23 @@ static ssize_t ad5791_write_dac_powerdown(struct iio_dev *indio_dev,
> uintptr_t private, const struct iio_chan_spec *chan, const char *buf,
> size_t len)
> {
> - long readin;
> + bool pwr_down;
> int ret;
> struct ad5791_state *st = iio_priv(indio_dev);
>
> - ret = strict_strtol(buf, 10,&readin);
> + ret = strtobool(buf,&pwr_down);
> if (ret)
> return ret;
>
> - if (readin == 0) {
> - st->pwr_down = false;
> + if (!pwr_down) {
> st->ctrl&= ~(AD5791_CTRL_OPGND | AD5791_CTRL_DACTRI);
> - } else if (readin == 1) {
> - st->pwr_down = true;
> + } else {
> if (st->pwr_down_mode == AD5791_DAC_PWRDN_6K)
> st->ctrl |= AD5791_CTRL_OPGND;
> else if (st->pwr_down_mode == AD5791_DAC_PWRDN_3STATE)
> st->ctrl |= AD5791_CTRL_DACTRI;
> - } else
> - ret = -EINVAL;
> + }
> + st->pwr_down = pwr_down;
>
> ret = ad5791_spi_write(st->spi, AD5791_ADDR_CTRL, st->ctrl);
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-05-15 7:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-15 7:52 [PATCH 1/3] staging:iio:dac:ad5504: Use strtobool for boolean values Lars-Peter Clausen
2012-05-15 7:52 ` [PATCH 2/3] staging:iio:dac:ad5624r: " Lars-Peter Clausen
2012-05-15 7:54 ` Jonathan Cameron
2012-05-15 7:52 ` [PATCH 3/3] staging:iio:dac:ad5791: " Lars-Peter Clausen
2012-05-15 7:54 ` Jonathan Cameron
2012-05-15 7:54 ` [PATCH 1/3] staging:iio:dac:ad5504: " Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).