From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ns.pmeerw.net ([87.118.82.44]:59017 "EHLO pmeerw.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752393Ab2EQA3n (ORCPT ); Wed, 16 May 2012 20:29:43 -0400 From: Peter Meerwald To: Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, Peter Meerwald Subject: [PATCH 5/9] iio: add check for measurement configuration value passed to hmc5843 Date: Thu, 17 May 2012 02:28:09 +0200 Message-Id: <1337214493-28773-3-git-send-email-pmeerw@pmeerw.net> In-Reply-To: <1337214493-28773-1-git-send-email-pmeerw@pmeerw.net> References: <1337214493-28773-1-git-send-email-pmeerw@pmeerw.net> Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org Signed-off-by: Peter Meerwald Acked-by: Jonathan Cameron --- drivers/staging/iio/magnetometer/hmc5843.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/staging/iio/magnetometer/hmc5843.c b/drivers/staging/iio/magnetometer/hmc5843.c index 6888e04..57ab4fb 100644 --- a/drivers/staging/iio/magnetometer/hmc5843.c +++ b/drivers/staging/iio/magnetometer/hmc5843.c @@ -281,9 +281,14 @@ static ssize_t hmc5843_set_measurement_configuration(struct device *dev, struct i2c_client *client = to_i2c_client(indio_dev->dev.parent); struct hmc5843_data *data = iio_priv(indio_dev); unsigned long meas_conf = 0; - int error = kstrtoul(buf, 10, &meas_conf); + int error; + + error = kstrtoul(buf, 10, &meas_conf); if (error) return error; + if (meas_conf >= HMC5843_MEAS_CONF_NOT_USED) + return -EINVAL; + mutex_lock(&data->lock); dev_dbg(dev, "set mode to %lu\n", meas_conf); -- 1.7.5.4