* [PATCH 1/2] iio: remove indio_dev pointer from max517_data
@ 2012-06-07 8:31 Peter Meerwald
2012-06-07 8:31 ` [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit Peter Meerwald
2012-06-07 10:15 ` [PATCH 1/2] iio: remove indio_dev pointer from max517_data Roland Stigge
0 siblings, 2 replies; 7+ messages in thread
From: Peter Meerwald @ 2012-06-07 8:31 UTC (permalink / raw)
To: linux-iio; +Cc: stigge, Peter Meerwald
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
drivers/iio/dac/max517.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c
index 92c77c8..352abe2 100644
--- a/drivers/iio/dac/max517.c
+++ b/drivers/iio/dac/max517.c
@@ -43,7 +43,6 @@ enum max517_device_ids {
};
struct max517_data {
- struct iio_dev *indio_dev;
struct i2c_client *client;
unsigned short vref_mv[2];
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit
2012-06-07 8:31 [PATCH 1/2] iio: remove indio_dev pointer from max517_data Peter Meerwald
@ 2012-06-07 8:31 ` Peter Meerwald
2012-06-07 10:16 ` Roland Stigge
2012-06-07 10:15 ` [PATCH 1/2] iio: remove indio_dev pointer from max517_data Roland Stigge
1 sibling, 1 reply; 7+ messages in thread
From: Peter Meerwald @ 2012-06-07 8:31 UTC (permalink / raw)
To: linux-iio; +Cc: stigge, Peter Meerwald
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
drivers/iio/dac/max517.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c
index 352abe2..c3d748c 100644
--- a/drivers/iio/dac/max517.c
+++ b/drivers/iio/dac/max517.c
@@ -156,7 +156,7 @@ static const struct iio_chan_spec max517_channels[] = {
MAX517_CHANNEL(1)
};
-static int max517_probe(struct i2c_client *client,
+static int __devinit max517_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct max517_data *data;
@@ -210,7 +210,7 @@ exit:
return err;
}
-static int max517_remove(struct i2c_client *client)
+static int __devexit max517_remove(struct i2c_client *client)
{
iio_device_unregister(i2c_get_clientdata(client));
iio_device_free(i2c_get_clientdata(client));
@@ -232,7 +232,7 @@ static struct i2c_driver max517_driver = {
.pm = MAX517_PM_OPS,
},
.probe = max517_probe,
- .remove = max517_remove,
+ .remove = __devexit_p(max517_remove),
.id_table = max517_id,
};
module_i2c_driver(max517_driver);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] iio: remove indio_dev pointer from max517_data
2012-06-07 8:31 [PATCH 1/2] iio: remove indio_dev pointer from max517_data Peter Meerwald
2012-06-07 8:31 ` [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit Peter Meerwald
@ 2012-06-07 10:15 ` Roland Stigge
2012-06-07 16:01 ` Jonathan Cameron
1 sibling, 1 reply; 7+ messages in thread
From: Roland Stigge @ 2012-06-07 10:15 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio
On 07/06/12 10:31, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: Roland Stigge <stigge@antcom.de>
> ---
> drivers/iio/dac/max517.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c
> index 92c77c8..352abe2 100644
> --- a/drivers/iio/dac/max517.c
> +++ b/drivers/iio/dac/max517.c
> @@ -43,7 +43,6 @@ enum max517_device_ids {
> };
>
> struct max517_data {
> - struct iio_dev *indio_dev;
> struct i2c_client *client;
> unsigned short vref_mv[2];
> };
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit
2012-06-07 8:31 ` [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit Peter Meerwald
@ 2012-06-07 10:16 ` Roland Stigge
2012-06-07 16:01 ` Jonathan Cameron
0 siblings, 1 reply; 7+ messages in thread
From: Roland Stigge @ 2012-06-07 10:16 UTC (permalink / raw)
To: Peter Meerwald; +Cc: linux-iio
On 07/06/12 10:31, Peter Meerwald wrote:
> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: Roland Stigge <stigge@antcom.de>
> ---
> drivers/iio/dac/max517.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c
> index 352abe2..c3d748c 100644
> --- a/drivers/iio/dac/max517.c
> +++ b/drivers/iio/dac/max517.c
> @@ -156,7 +156,7 @@ static const struct iio_chan_spec max517_channels[] = {
> MAX517_CHANNEL(1)
> };
>
> -static int max517_probe(struct i2c_client *client,
> +static int __devinit max517_probe(struct i2c_client *client,
> const struct i2c_device_id *id)
> {
> struct max517_data *data;
> @@ -210,7 +210,7 @@ exit:
> return err;
> }
>
> -static int max517_remove(struct i2c_client *client)
> +static int __devexit max517_remove(struct i2c_client *client)
> {
> iio_device_unregister(i2c_get_clientdata(client));
> iio_device_free(i2c_get_clientdata(client));
> @@ -232,7 +232,7 @@ static struct i2c_driver max517_driver = {
> .pm = MAX517_PM_OPS,
> },
> .probe = max517_probe,
> - .remove = max517_remove,
> + .remove = __devexit_p(max517_remove),
> .id_table = max517_id,
> };
> module_i2c_driver(max517_driver);
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit
2012-06-07 10:16 ` Roland Stigge
@ 2012-06-07 16:01 ` Jonathan Cameron
0 siblings, 0 replies; 7+ messages in thread
From: Jonathan Cameron @ 2012-06-07 16:01 UTC (permalink / raw)
To: Roland Stigge; +Cc: Peter Meerwald, linux-iio
On 06/07/2012 11:16 AM, Roland Stigge wrote:
> On 07/06/12 10:31, Peter Meerwald wrote:
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
>
> Acked-by: Roland Stigge <stigge@antcom.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
Please send on to Greg KH.
>
>> ---
>> drivers/iio/dac/max517.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c
>> index 352abe2..c3d748c 100644
>> --- a/drivers/iio/dac/max517.c
>> +++ b/drivers/iio/dac/max517.c
>> @@ -156,7 +156,7 @@ static const struct iio_chan_spec max517_channels[] = {
>> MAX517_CHANNEL(1)
>> };
>>
>> -static int max517_probe(struct i2c_client *client,
>> +static int __devinit max517_probe(struct i2c_client *client,
>> const struct i2c_device_id *id)
>> {
>> struct max517_data *data;
>> @@ -210,7 +210,7 @@ exit:
>> return err;
>> }
>>
>> -static int max517_remove(struct i2c_client *client)
>> +static int __devexit max517_remove(struct i2c_client *client)
>> {
>> iio_device_unregister(i2c_get_clientdata(client));
>> iio_device_free(i2c_get_clientdata(client));
>> @@ -232,7 +232,7 @@ static struct i2c_driver max517_driver = {
>> .pm = MAX517_PM_OPS,
>> },
>> .probe = max517_probe,
>> - .remove = max517_remove,
>> + .remove = __devexit_p(max517_remove),
>> .id_table = max517_id,
>> };
>> module_i2c_driver(max517_driver);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] iio: remove indio_dev pointer from max517_data
2012-06-07 10:15 ` [PATCH 1/2] iio: remove indio_dev pointer from max517_data Roland Stigge
@ 2012-06-07 16:01 ` Jonathan Cameron
0 siblings, 0 replies; 7+ messages in thread
From: Jonathan Cameron @ 2012-06-07 16:01 UTC (permalink / raw)
To: Roland Stigge; +Cc: Peter Meerwald, linux-iio
On 06/07/2012 11:15 AM, Roland Stigge wrote:
> On 07/06/12 10:31, Peter Meerwald wrote:
>> Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
>
Well that would explain where the other one came from ;)
> Acked-by: Roland Stigge <stigge@antcom.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
>
>> ---
>> drivers/iio/dac/max517.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c
>> index 92c77c8..352abe2 100644
>> --- a/drivers/iio/dac/max517.c
>> +++ b/drivers/iio/dac/max517.c
>> @@ -43,7 +43,6 @@ enum max517_device_ids {
>> };
>>
>> struct max517_data {
>> - struct iio_dev *indio_dev;
>> struct i2c_client *client;
>> unsigned short vref_mv[2];
>> };
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit
2012-06-08 6:54 Peter Meerwald
@ 2012-06-08 6:54 ` Peter Meerwald
0 siblings, 0 replies; 7+ messages in thread
From: Peter Meerwald @ 2012-06-08 6:54 UTC (permalink / raw)
To: Greg KH; +Cc: linux-iio, Peter Meerwald
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
Acked-by: Roland Stigge <stigge@antcom.de>
Acked-by: Jonathan Cameron <jic23@kernel.org>
---
drivers/iio/dac/max517.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/iio/dac/max517.c b/drivers/iio/dac/max517.c
index 352abe2..c3d748c 100644
--- a/drivers/iio/dac/max517.c
+++ b/drivers/iio/dac/max517.c
@@ -156,7 +156,7 @@ static const struct iio_chan_spec max517_channels[] = {
MAX517_CHANNEL(1)
};
-static int max517_probe(struct i2c_client *client,
+static int __devinit max517_probe(struct i2c_client *client,
const struct i2c_device_id *id)
{
struct max517_data *data;
@@ -210,7 +210,7 @@ exit:
return err;
}
-static int max517_remove(struct i2c_client *client)
+static int __devexit max517_remove(struct i2c_client *client)
{
iio_device_unregister(i2c_get_clientdata(client));
iio_device_free(i2c_get_clientdata(client));
@@ -232,7 +232,7 @@ static struct i2c_driver max517_driver = {
.pm = MAX517_PM_OPS,
},
.probe = max517_probe,
- .remove = max517_remove,
+ .remove = __devexit_p(max517_remove),
.id_table = max517_id,
};
module_i2c_driver(max517_driver);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-06-08 6:54 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-07 8:31 [PATCH 1/2] iio: remove indio_dev pointer from max517_data Peter Meerwald
2012-06-07 8:31 ` [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit Peter Meerwald
2012-06-07 10:16 ` Roland Stigge
2012-06-07 16:01 ` Jonathan Cameron
2012-06-07 10:15 ` [PATCH 1/2] iio: remove indio_dev pointer from max517_data Roland Stigge
2012-06-07 16:01 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2012-06-08 6:54 Peter Meerwald
2012-06-08 6:54 ` [PATCH 2/2] iio: max517: mark probe() and remove() with __devinit and __devexit Peter Meerwald
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).