* [PATCH] iio: ad9523: Fix argument type mismatch
@ 2012-06-08 11:04 michael.hennerich
0 siblings, 0 replies; 7+ messages in thread
From: michael.hennerich @ 2012-06-08 11:04 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, device-drivers-devel, dan.carpenter, Michael Hennerich
From: Michael Hennerich <michael.hennerich@analog.com>
drivers/iio/frequency/ad9523.c:378 ad9523_vco_out_map()
warn: value 2 can't fit into 1 'out'
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/iio/frequency/ad9523.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
index 7272924..43f47d9 100644
--- a/drivers/iio/frequency/ad9523.c
+++ b/drivers/iio/frequency/ad9523.c
@@ -361,7 +361,7 @@ static int ad9523_io_update(struct iio_dev *indio_dev)
}
static int ad9523_vco_out_map(struct iio_dev *indio_dev,
- unsigned ch, bool out)
+ unsigned ch, unsigned out)
{
struct ad9523_state *st = iio_priv(indio_dev);
int ret;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] iio: ad9523: Fix argument type mismatch
@ 2012-06-11 7:51 michael.hennerich
2012-06-11 9:02 ` Shubhrajyoti Datta
0 siblings, 1 reply; 7+ messages in thread
From: michael.hennerich @ 2012-06-11 7:51 UTC (permalink / raw)
To: gregkh; +Cc: jic23, linux-iio, device-drivers-devel, Michael Hennerich
From: Michael Hennerich <michael.hennerich@analog.com>
drivers/iio/frequency/ad9523.c:378 ad9523_vco_out_map()
warn: value 2 can't fit into 1 'out'
Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/iio/frequency/ad9523.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
index 7272924..43f47d9 100644
--- a/drivers/iio/frequency/ad9523.c
+++ b/drivers/iio/frequency/ad9523.c
@@ -361,7 +361,7 @@ static int ad9523_io_update(struct iio_dev *indio_dev)
}
static int ad9523_vco_out_map(struct iio_dev *indio_dev,
- unsigned ch, bool out)
+ unsigned ch, unsigned out)
{
struct ad9523_state *st = iio_priv(indio_dev);
int ret;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] iio: ad9523: Fix argument type mismatch
2012-06-11 7:51 michael.hennerich
@ 2012-06-11 9:02 ` Shubhrajyoti Datta
2012-06-11 9:15 ` Michael Hennerich
0 siblings, 1 reply; 7+ messages in thread
From: Shubhrajyoti Datta @ 2012-06-11 9:02 UTC (permalink / raw)
To: michael.hennerich; +Cc: gregkh, jic23, linux-iio, device-drivers-devel
Hi Michael,
On Mon, Jun 11, 2012 at 1:21 PM, <michael.hennerich@analog.com> wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> drivers/iio/frequency/ad9523.c:378 ad9523_vco_out_map()
> =A0 =A0 =A0 =A0 warn: value 2 can't fit into 1 'out'
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> =A0drivers/iio/frequency/ad9523.c | =A0 =A02 +-
> =A01 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad952=
3.c
> index 7272924..43f47d9 100644
> --- a/drivers/iio/frequency/ad9523.c
> +++ b/drivers/iio/frequency/ad9523.c
> @@ -361,7 +361,7 @@ static int ad9523_io_update(struct iio_dev *indio_dev=
)
> =A0}
>
> =A0static int ad9523_vco_out_map(struct iio_dev *indio_dev,
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsigned ch, bo=
ol out)
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsigned ch, un=
signed out)
Unsigned defaults to unsigned int right shouldnt it be a char?
Or am I missing something.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iio: ad9523: Fix argument type mismatch
2012-06-11 9:02 ` Shubhrajyoti Datta
@ 2012-06-11 9:15 ` Michael Hennerich
2012-06-11 11:17 ` Shubhrajyoti Datta
0 siblings, 1 reply; 7+ messages in thread
From: Michael Hennerich @ 2012-06-11 9:15 UTC (permalink / raw)
To: Shubhrajyoti Datta
Cc: gregkh@linuxfoundation.org, jic23@kernel.org,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
On 06/11/2012 11:02 AM, Shubhrajyoti Datta wrote:
> Hi Michael,
>
> On Mon, Jun 11, 2012 at 1:21 PM,<michael.hennerich@analog.com> wrote:
>> From: Michael Hennerich<michael.hennerich@analog.com>
>>
>> drivers/iio/frequency/ad9523.c:378 ad9523_vco_out_map()
>> warn: value 2 can't fit into 1 'out'
>>
>> Signed-off-by: Michael Hennerich<michael.hennerich@analog.com>
>> Reported-by: Dan Carpenter<dan.carpenter@oracle.com>
>> ---
>> drivers/iio/frequency/ad9523.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/iio/frequency/ad9523.c b/drivers/iio/frequency/ad9523.c
>> index 7272924..43f47d9 100644
>> --- a/drivers/iio/frequency/ad9523.c
>> +++ b/drivers/iio/frequency/ad9523.c
>> @@ -361,7 +361,7 @@ static int ad9523_io_update(struct iio_dev *indio_dev)
>> }
>>
>> static int ad9523_vco_out_map(struct iio_dev *indio_dev,
>> - unsigned ch, bool out)
>> + unsigned ch, unsigned out)
> Unsigned defaults to unsigned int right shouldnt it be a char?
> Or am I missing something.
>
Hi Shubhrajyoti,
can you explain why this matters?
If you take a closer look at the disassembly -
you will notice that 'unsigned int' will generate nicer code.
--
Greetings,
Michael
--
Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] iio: ad9523: Fix argument type mismatch
2012-06-11 9:15 ` Michael Hennerich
@ 2012-06-11 11:17 ` Shubhrajyoti Datta
2012-06-11 11:36 ` Lars-Peter Clausen
0 siblings, 1 reply; 7+ messages in thread
From: Shubhrajyoti Datta @ 2012-06-11 11:17 UTC (permalink / raw)
To: michael.hennerich
Cc: gregkh@linuxfoundation.org, jic23@kernel.org,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
Hi Michael,
On Mon, Jun 11, 2012 at 2:45 PM, Michael Hennerich
<michael.hennerich@analog.com> wrote:
[..]
>>> =A0static int ad9523_vco_out_map(struct iio_dev *indio_dev,
>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsigned ch, =
bool out)
>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsigned ch, =
unsigned out)
>>
>> Unsigned defaults to unsigned int right shouldnt it be a char?
>> Or am I missing something.
>>
> Hi Shubhrajyoti,
>
> can you explain why this matters?
> If you take a closer look at the disassembly -
> you will notice that 'unsigned int' will generate nicer code.
>
What I was thinking is that
+ }
+
+ st->vco_out_map[ch] =3D out;
+
+ return ret;
+}
Here
and
+struct ad9523_state {
+ struct spi_device *spi;
+ struct regulator *reg;
+ struct ad9523_platform_data *pdata;
+ struct iio_chan_spec ad9523_channels[AD9523_NUM_CHAN];
+
+ unsigned long vcxo_freq;
+ unsigned long vco_freq;
+ unsigned long vco_out_freq[AD9523_NUM_CLK_SRC];
+ unsigned char vco_out_map[AD9523_NUM_CHAN_ALT_CLK_SRC];
So that may not work well with all the endianness etc,
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] iio: ad9523: Fix argument type mismatch
2012-06-11 11:17 ` Shubhrajyoti Datta
@ 2012-06-11 11:36 ` Lars-Peter Clausen
2012-06-11 12:29 ` Shubhrajyoti Datta
0 siblings, 1 reply; 7+ messages in thread
From: Lars-Peter Clausen @ 2012-06-11 11:36 UTC (permalink / raw)
To: Shubhrajyoti Datta
Cc: michael.hennerich, gregkh@linuxfoundation.org, jic23@kernel.org,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
On 06/11/2012 01:17 PM, Shubhrajyoti Datta wrote:
> Hi Michael,
>
> On Mon, Jun 11, 2012 at 2:45 PM, Michael Hennerich
> <michael.hennerich@analog.com> wrote:
> [..]
>>>> static int ad9523_vco_out_map(struct iio_dev *indio_dev,
>>>> - unsigned ch, bool out)
>>>> + unsigned ch, unsigned out)
>>>
>>> Unsigned defaults to unsigned int right shouldnt it be a char?
>>> Or am I missing something.
>>>
>> Hi Shubhrajyoti,
>>
>> can you explain why this matters?
>> If you take a closer look at the disassembly -
>> you will notice that 'unsigned int' will generate nicer code.
>>
>
> What I was thinking is that
>
>
> + }
> +
> + st->vco_out_map[ch] = out;
> +
> + return ret;
> +}
> Here
>
> and
> +struct ad9523_state {
> + struct spi_device *spi;
> + struct regulator *reg;
> + struct ad9523_platform_data *pdata;
> + struct iio_chan_spec ad9523_channels[AD9523_NUM_CHAN];
> +
> + unsigned long vcxo_freq;
> + unsigned long vco_freq;
> + unsigned long vco_out_freq[AD9523_NUM_CLK_SRC];
> + unsigned char vco_out_map[AD9523_NUM_CHAN_ALT_CLK_SRC];
>
> So that may not work well with all the endianness etc,
The code is fine as it is, the assignment does an implicit type cast.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] iio: ad9523: Fix argument type mismatch
2012-06-11 11:36 ` Lars-Peter Clausen
@ 2012-06-11 12:29 ` Shubhrajyoti Datta
0 siblings, 0 replies; 7+ messages in thread
From: Shubhrajyoti Datta @ 2012-06-11 12:29 UTC (permalink / raw)
To: Lars-Peter Clausen
Cc: michael.hennerich, gregkh@linuxfoundation.org, jic23@kernel.org,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
On Mon, Jun 11, 2012 at 5:06 PM, Lars-Peter Clausen <lars@metafoo.de> wrote=
:
> On 06/11/2012 01:17 PM, Shubhrajyoti Datta wrote:
>> Hi Michael,
>>
>> On Mon, Jun 11, 2012 at 2:45 PM, Michael Hennerich
>> <michael.hennerich@analog.com> wrote:
>> [..]
>>>>> =A0static int ad9523_vco_out_map(struct iio_dev *indio_dev,
>>>>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsigned ch=
, bool out)
>>>>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsigned ch=
, unsigned out)
>>>>
>>>> Unsigned defaults to unsigned int right shouldnt it be a char?
>>>> Or am I missing something.
>>>>
>
> The code is fine as it is, the assignment does an implicit type cast.
Ok got is now . Apologies for the noise.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-06-11 12:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-08 11:04 [PATCH] iio: ad9523: Fix argument type mismatch michael.hennerich
-- strict thread matches above, loose matches on Subject: below --
2012-06-11 7:51 michael.hennerich
2012-06-11 9:02 ` Shubhrajyoti Datta
2012-06-11 9:15 ` Michael Hennerich
2012-06-11 11:17 ` Shubhrajyoti Datta
2012-06-11 11:36 ` Lars-Peter Clausen
2012-06-11 12:29 ` Shubhrajyoti Datta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).