From: Lars Poeschel <larsi@wh2.tu-dresden.de>
To: linus.walleij@linaro.org
Cc: poeschel@lemonage.de, sameo@linux.intel.com,
linux-kernel@vger.kernel.org, jic23@cam.ac.uk,
khali@linux-fr.org, ben-linux@fluff.org, w.sang@pengutronix.de,
grant.likely@secretlab.ca, linux-iio@vger.kernel.org
Subject: [PATCH v3 1/5] mfd: set device type of mfd platform devices to a mfd type
Date: Mon, 5 Nov 2012 15:48:22 +0100 [thread overview]
Message-ID: <1352126906-4560-1-git-send-email-larsi@wh2.tu-dresden.de> (raw)
From: Lars Poeschel <poeschel@lemonage.de>
This sets the type of the platform devices that are added
to the mfd core to some mfd-cell type. This enables us
to add mfd cells to platform devices, that are in use by
other cores (e.g. the usb core).
Otherwise by removing the mfd cell from a platform device
that already has some "childs" would remove all childs,
not only the mfd ones.
Thanks to Lars-Peter Clausen for proposing this.
Signed-off-by: Lars Poeschel <poeschel@lemonage.de>
---
drivers/mfd/mfd-core.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
index f8b7771..d317b50 100644
--- a/drivers/mfd/mfd-core.c
+++ b/drivers/mfd/mfd-core.c
@@ -21,6 +21,10 @@
#include <linux/irqdomain.h>
#include <linux/of.h>
+static struct device_type const mfd_device_type = {
+ .name = "mfd-cell",
+};
+
int mfd_cell_enable(struct platform_device *pdev)
{
const struct mfd_cell *cell = mfd_get_cell(pdev);
@@ -91,6 +95,7 @@ static int mfd_add_device(struct device *parent, int id,
goto fail_device;
pdev->dev.parent = parent;
+ pdev->dev.type = &mfd_device_type;
if (parent->of_node && cell->of_compatible) {
for_each_child_of_node(parent->of_node, np) {
@@ -204,10 +209,16 @@ EXPORT_SYMBOL(mfd_add_devices);
static int mfd_remove_devices_fn(struct device *dev, void *c)
{
- struct platform_device *pdev = to_platform_device(dev);
- const struct mfd_cell *cell = mfd_get_cell(pdev);
+ struct platform_device *pdev;
+ const struct mfd_cell *cell;
atomic_t **usage_count = c;
+ if (dev->type != &mfd_device_type)
+ return 0;
+
+ pdev = to_platform_device(dev);
+ cell = mfd_get_cell(pdev);
+
/* find the base address of usage_count pointers (for freeing) */
if (!*usage_count || (cell->usage_count < *usage_count))
*usage_count = cell->usage_count;
--
1.7.10.4
next reply other threads:[~2012-11-05 13:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 14:48 Lars Poeschel [this message]
2012-11-05 14:48 ` [PATCH v3 2/5] mfd: add viperboard driver Lars Poeschel
2012-11-19 17:30 ` Samuel Ortiz
2012-11-20 8:34 ` Wolfram Sang
2012-11-20 9:44 ` Lars Poeschel
2012-11-05 14:48 ` [PATCH v3 3/5] gpio: add viperboard gpio driver Lars Poeschel
2012-11-06 8:23 ` Linus Walleij
2012-11-05 14:48 ` [PATCH v3 4/5] i2c: add viperboard i2c master driver Lars Poeschel
2012-11-19 15:36 ` [PATCH v4 " Lars Poeschel
2012-11-05 14:48 ` [PATCH v3 5/5] iio: adc: add viperboard adc driver Lars Poeschel
2012-11-05 15:57 ` Lars-Peter Clausen
2012-11-05 20:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352126906-4560-1-git-send-email-larsi@wh2.tu-dresden.de \
--to=larsi@wh2.tu-dresden.de \
--cc=ben-linux@fluff.org \
--cc=grant.likely@secretlab.ca \
--cc=jic23@cam.ac.uk \
--cc=khali@linux-fr.org \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=poeschel@lemonage.de \
--cc=sameo@linux.intel.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).