From: Axel Lin <axel.lin@ingics.com>
To: Jonathan Cameron <jic23@cam.ac.uk>
Cc: Michael Hennerich <hennerich@blackfin.uclinux.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 5/6] iio: dac: ad5686: Don't set error code to voltage_uv
Date: Fri, 14 Dec 2012 15:54:04 +0800 [thread overview]
Message-ID: <1355471644.11297.9.camel@phoenix> (raw)
In-Reply-To: <1355471245.11297.1.camel@phoenix>
regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/iio/dac/ad5686.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
index bc92ff9..28f2e59 100644
--- a/drivers/iio/dac/ad5686.c
+++ b/drivers/iio/dac/ad5686.c
@@ -332,7 +332,11 @@ static int __devinit ad5686_probe(struct spi_device *spi)
if (ret)
goto error_put_reg;
- voltage_uv = regulator_get_voltage(st->reg);
+ ret = regulator_get_voltage(st->reg);
+ if (ret)
+ goto error_disable_reg;
+
+ voltage_uv = ret;
}
st->chip_info =
--
1.7.9.5
next prev parent reply other threads:[~2012-12-14 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-14 7:47 [PATCH 1/6] iio: adc: ad7266: Don't set error code to st->vref_uv Axel Lin
2012-12-14 7:48 ` [PATCH 2/6] iio: dac: ad5380: Don't set error code to st->vref Axel Lin
2012-12-14 7:51 ` [PATCH 3/6] iio: dac: ad5504: Don't set error code to voltage_uv Axel Lin
2012-12-14 7:52 ` [PATCH 4/6] iio: dac: ad5624r_spi: " Axel Lin
2012-12-14 7:54 ` Axel Lin [this message]
2012-12-14 7:55 ` [PATCH 6/6] iio: dac: ad5791: Don't set error code to [pos|neg]_voltage_uv Axel Lin
2012-12-14 9:56 ` [PATCH 1/6] iio: adc: ad7266: Don't set error code to st->vref_uv Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355471644.11297.9.camel@phoenix \
--to=axel.lin@ingics.com \
--cc=hennerich@blackfin.uclinux.org \
--cc=jic23@cam.ac.uk \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).