* [PATCH v2] iio: dac: ad5446: Don't set error code to voltage_uv
@ 2012-12-18 3:33 Axel Lin
2012-12-18 19:23 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2012-12-18 3:33 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: Michael Hennerich, linux-iio, linux-kernel
regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Sorry. Just found I made the same mistake again.
Here is v2, should check if ret is negative value.
drivers/iio/dac/ad5446.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
index 3310cbb..607378f 100644
--- a/drivers/iio/dac/ad5446.c
+++ b/drivers/iio/dac/ad5446.c
@@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,
if (ret)
goto error_put_reg;
- voltage_uv = regulator_get_voltage(reg);
+ ret = regulator_get_voltage(reg);
+ if (ret < 0)
+ goto error_disable_reg;
+
+ voltage_uv = ret;
}
indio_dev = iio_device_alloc(sizeof(*st));
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] iio: dac: ad5446: Don't set error code to voltage_uv
2012-12-18 3:33 [PATCH v2] iio: dac: ad5446: Don't set error code to voltage_uv Axel Lin
@ 2012-12-18 19:23 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2012-12-18 19:23 UTC (permalink / raw)
To: Axel Lin; +Cc: Jonathan Cameron, Michael Hennerich, linux-iio, linux-kernel
On 12/18/2012 03:33 AM, Axel Lin wrote:
> regulator_get_voltage() may return negative error code.
> Add error checking to avoid setting error code to voltage_uv.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
added to fixes-togreg branch of iio.git
> ---
> Sorry. Just found I made the same mistake again.
> Here is v2, should check if ret is negative value.
> drivers/iio/dac/ad5446.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> index 3310cbb..607378f 100644
> --- a/drivers/iio/dac/ad5446.c
> +++ b/drivers/iio/dac/ad5446.c
> @@ -226,7 +226,11 @@ static int __devinit ad5446_probe(struct device *dev, const char *name,
> if (ret)
> goto error_put_reg;
>
> - voltage_uv = regulator_get_voltage(reg);
> + ret = regulator_get_voltage(reg);
> + if (ret < 0)
> + goto error_disable_reg;
> +
> + voltage_uv = ret;
> }
>
> indio_dev = iio_device_alloc(sizeof(*st));
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-12-18 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-18 3:33 [PATCH v2] iio: dac: ad5446: Don't set error code to voltage_uv Axel Lin
2012-12-18 19:23 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).