linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org
Cc: linux-kernel@vger.kernel.org,
	Yuanhan Liu <yuanhan.liu@linux.intel.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Jonathan Cameron <jic23@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [PATCH] staging:iio:adis16260: select IIO_ADIS_LIB to fix build error
Date: Mon, 31 Dec 2012 13:36:35 +0800	[thread overview]
Message-ID: <1356932195-31437-1-git-send-email-yuanhan.liu@linux.intel.com> (raw)

Commit 9d5e9fdf turned the code to use adis library, so it depends on
adis lib. But it forgot to select it at Kconfig file. Thus if adis is
not enabled, it will produce following build errros(catched by Fengguang's
0-DAY kernel build testing system):
  ERROR: "adis_initial_startup" [drivers/staging/iio/gyro/adis16260.ko] undefined!
  ERROR: "adis_init" [drivers/staging/iio/gyro/adis16260.ko] undefined!
  ERROR: "adis_write_reg" [drivers/staging/iio/gyro/adis16260.ko] undefined!
  ERROR: "adis_read_reg" [drivers/staging/iio/gyro/adis16260.ko] undefined!
  ERROR: "adis_single_conversion" [drivers/staging/iio/gyro/adis16260.ko] undefined!

Selecting IIO_ADIS_LIB at Kconfig file fixes this issue.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
---
 drivers/staging/iio/gyro/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/iio/gyro/Kconfig b/drivers/staging/iio/gyro/Kconfig
index ea295b2..476207a 100644
--- a/drivers/staging/iio/gyro/Kconfig
+++ b/drivers/staging/iio/gyro/Kconfig
@@ -27,6 +27,7 @@ config ADIS16130
 config ADIS16260
 	tristate "Analog Devices ADIS16260 Digital Gyroscope Sensor SPI driver"
 	depends on SPI
+	select IIO_ADIS_LIB
 	select IIO_TRIGGER if IIO_BUFFER
 	select IIO_SW_RING if IIO_BUFFER
 	help
-- 
1.7.7.6


             reply	other threads:[~2012-12-31  5:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-31  5:36 Yuanhan Liu [this message]
2012-12-31  7:16 ` [PATCH] staging:iio:adis16260: select IIO_ADIS_LIB to fix build error Lars-Peter Clausen
2012-12-31  7:24   ` Yuanhan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1356932195-31437-1-git-send-email-yuanhan.liu@linux.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).