From: Sachin Kamat <sachin.kamat@linaro.org>
To: linux-iio@vger.kernel.org
Cc: jic23@kernel.org, jic23@cam.ac.uk, sachin.kamat@linaro.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 2/9] iio: gyro: adis16130: Use devm_iio_device_alloc
Date: Tue, 13 Aug 2013 12:04:28 +0530 [thread overview]
Message-ID: <1376375675-11595-2-git-send-email-sachin.kamat@linaro.org> (raw)
In-Reply-To: <1376375675-11595-1-git-send-email-sachin.kamat@linaro.org>
Using devm_iio_device_alloc makes code simpler.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/iio/gyro/adis16130.c | 23 ++++-------------------
1 file changed, 4 insertions(+), 19 deletions(-)
diff --git a/drivers/iio/gyro/adis16130.c b/drivers/iio/gyro/adis16130.c
index 129acdf..ac66fc1 100644
--- a/drivers/iio/gyro/adis16130.c
+++ b/drivers/iio/gyro/adis16130.c
@@ -148,16 +148,13 @@ static const struct iio_info adis16130_info = {
static int adis16130_probe(struct spi_device *spi)
{
- int ret;
struct adis16130_state *st;
struct iio_dev *indio_dev;
/* setup the industrialio driver allocated elements */
- indio_dev = iio_device_alloc(sizeof(*st));
- if (indio_dev == NULL) {
- ret = -ENOMEM;
- goto error_ret;
- }
+ indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
+ if (!indio_dev)
+ return -ENOMEM;
st = iio_priv(indio_dev);
/* this is only used for removal purposes */
spi_set_drvdata(spi, indio_dev);
@@ -170,24 +167,12 @@ static int adis16130_probe(struct spi_device *spi)
indio_dev->info = &adis16130_info;
indio_dev->modes = INDIO_DIRECT_MODE;
- ret = iio_device_register(indio_dev);
- if (ret)
- goto error_free_dev;
-
- return 0;
-
-error_free_dev:
- iio_device_free(indio_dev);
-
-error_ret:
- return ret;
+ return iio_device_register(indio_dev);
}
static int adis16130_remove(struct spi_device *spi)
{
iio_device_unregister(spi_get_drvdata(spi));
- iio_device_free(spi_get_drvdata(spi));
-
return 0;
}
--
1.7.9.5
next prev parent reply other threads:[~2013-08-13 6:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 6:34 [PATCH 1/9] iio: gyro: adis16080: Use devm_iio_device_alloc Sachin Kamat
2013-08-13 6:34 ` Sachin Kamat [this message]
2013-08-13 18:35 ` [PATCH 2/9] iio: gyro: adis16130: " Jonathan Cameron
2013-08-13 6:34 ` [PATCH 3/9] iio: gyro: adis16136: " Sachin Kamat
2013-08-13 18:35 ` Jonathan Cameron
2013-08-13 6:34 ` [PATCH 4/9] iio: gyro: adis16260: " Sachin Kamat
2013-08-13 18:37 ` Jonathan Cameron
2013-08-13 6:34 ` [PATCH 5/9] iio: gyro: adxrs450: " Sachin Kamat
2013-08-13 18:38 ` Jonathan Cameron
2013-08-13 6:34 ` [PATCH 6/9] iio: hid-sensor-gyro-3d: " Sachin Kamat
2013-08-13 18:39 ` Jonathan Cameron
2013-08-13 6:34 ` [PATCH 7/9] iio: gyro: itg3200_core: " Sachin Kamat
2013-08-13 18:40 ` Jonathan Cameron
2013-08-13 6:34 ` [PATCH 8/9] iio: gyro: st_gyro: " Sachin Kamat
2013-08-13 18:41 ` Jonathan Cameron
2013-08-13 6:34 ` [PATCH 9/9] iio: gyro: adis16060_core: " Sachin Kamat
2013-08-13 18:42 ` Jonathan Cameron
2013-08-13 9:03 ` [PATCH 1/9] iio: gyro: adis16080: " Lars-Peter Clausen
2013-08-13 18:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1376375675-11595-2-git-send-email-sachin.kamat@linaro.org \
--to=sachin.kamat@linaro.org \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).