* [PATCH] staging:iio:dummy fix kfifo_buf kconfig dependency issue if kfifo modular and buffer enabled for built in dummy driver.
[not found] <20130723235123.GA25723@localhost>
@ 2013-09-01 17:55 ` Jonathan Cameron
2013-09-02 1:34 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Cameron @ 2013-09-01 17:55 UTC (permalink / raw)
To: linux-iio; +Cc: Randy Dunlap, fengguang.wu, Jonathan Cameron
This only occurs in the unlikely event that the example driver is built
in whilst the buffer implementation is not.
Solved by switching from a depends on to a select for this particular case.
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---
drivers/staging/iio/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
index db4d6dc..b36feb0 100644
--- a/drivers/staging/iio/Kconfig
+++ b/drivers/staging/iio/Kconfig
@@ -37,7 +37,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
config IIO_SIMPLE_DUMMY_BUFFER
boolean "Buffered capture support"
- depends on IIO_KFIFO_BUF
+ select IIO_KFIFO_BUF
help
Add buffered data capture to the simple dummy driver.
--
1.8.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging:iio:dummy fix kfifo_buf kconfig dependency issue if kfifo modular and buffer enabled for built in dummy driver.
2013-09-01 17:55 ` [PATCH] staging:iio:dummy fix kfifo_buf kconfig dependency issue if kfifo modular and buffer enabled for built in dummy driver Jonathan Cameron
@ 2013-09-02 1:34 ` Randy Dunlap
2013-09-08 11:26 ` Jonathan Cameron
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2013-09-02 1:34 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, fengguang.wu
On 09/01/13 10:55, Jonathan Cameron wrote:
> This only occurs in the unlikely event that the example driver is built
> in whilst the buffer implementation is not.
>
> Solved by switching from a depends on to a select for this particular case.
>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/staging/iio/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
> index db4d6dc..b36feb0 100644
> --- a/drivers/staging/iio/Kconfig
> +++ b/drivers/staging/iio/Kconfig
> @@ -37,7 +37,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
>
> config IIO_SIMPLE_DUMMY_BUFFER
> boolean "Buffered capture support"
> - depends on IIO_KFIFO_BUF
> + select IIO_KFIFO_BUF
> help
> Add buffered data capture to the simple dummy driver.
>
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging:iio:dummy fix kfifo_buf kconfig dependency issue if kfifo modular and buffer enabled for built in dummy driver.
2013-09-02 1:34 ` Randy Dunlap
@ 2013-09-08 11:26 ` Jonathan Cameron
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2013-09-08 11:26 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-iio, fengguang.wu
On 09/02/13 02:34, Randy Dunlap wrote:
> On 09/01/13 10:55, Jonathan Cameron wrote:
>> This only occurs in the unlikely event that the example driver is built
>> in whilst the buffer implementation is not.
>>
>> Solved by switching from a depends on to a select for this particular case.
>>
>> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
>> Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> Signed-off-by: Jonathan Cameron <jic23@kernel.org>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
applied to the fixes-togreg branch of iio.git. I'll send
this on to Greg once rc1 is out.
>
> Thanks.
>
>> ---
>> drivers/staging/iio/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig
>> index db4d6dc..b36feb0 100644
>> --- a/drivers/staging/iio/Kconfig
>> +++ b/drivers/staging/iio/Kconfig
>> @@ -37,7 +37,7 @@ config IIO_SIMPLE_DUMMY_EVENTS
>>
>> config IIO_SIMPLE_DUMMY_BUFFER
>> boolean "Buffered capture support"
>> - depends on IIO_KFIFO_BUF
>> + select IIO_KFIFO_BUF
>> help
>> Add buffered data capture to the simple dummy driver.
>>
>>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-08 10:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130723235123.GA25723@localhost>
2013-09-01 17:55 ` [PATCH] staging:iio:dummy fix kfifo_buf kconfig dependency issue if kfifo modular and buffer enabled for built in dummy driver Jonathan Cameron
2013-09-02 1:34 ` Randy Dunlap
2013-09-08 11:26 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).