From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, jic23@cam.ac.uk
Cc: arnd@arndb.de, linus.walleij@linaro.org, denis.ciocca@st.com,
linux-iio@vger.kernel.org, Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 23/38] iio: pressure-core: st: Describe LPS331AP defines by name
Date: Tue, 10 Sep 2013 13:49:24 +0100 [thread overview]
Message-ID: <1378817379-8238-24-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1378817379-8238-1-git-send-email-lee.jones@linaro.org>
They're currently named *_1_*, for 'Sensor 1', but the code will be much
more readable if we use the naming convention *_LPS331AP_* instead.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/iio/pressure/st_pressure_core.c | 94 ++++++++++++++++-----------------
1 file changed, 46 insertions(+), 48 deletions(-)
diff --git a/drivers/iio/pressure/st_pressure_core.c b/drivers/iio/pressure/st_pressure_core.c
index 279aafd..2ee4bcd 100644
--- a/drivers/iio/pressure/st_pressure_core.c
+++ b/drivers/iio/pressure/st_pressure_core.c
@@ -36,94 +36,92 @@
ST_PRESS_LSB_PER_CELSIUS)
#define ST_PRESS_NUMBER_DATA_CHANNELS 1
-/* DEFAULT VALUE FOR SENSORS */
-#define ST_PRESS_DEFAULT_OUT_XL_ADDR 0x28
-#define ST_TEMP_DEFAULT_OUT_L_ADDR 0x2b
-
/* FULLSCALE */
#define ST_PRESS_FS_AVL_1260MB 1260
-/* CUSTOM VALUES FOR SENSOR 1 */
-#define ST_PRESS_1_WAI_EXP 0xbb
-#define ST_PRESS_1_ODR_ADDR 0x20
-#define ST_PRESS_1_ODR_MASK 0x70
-#define ST_PRESS_1_ODR_AVL_1HZ_VAL 0x01
-#define ST_PRESS_1_ODR_AVL_7HZ_VAL 0x05
-#define ST_PRESS_1_ODR_AVL_13HZ_VAL 0x06
-#define ST_PRESS_1_ODR_AVL_25HZ_VAL 0x07
-#define ST_PRESS_1_PW_ADDR 0x20
-#define ST_PRESS_1_PW_MASK 0x80
-#define ST_PRESS_1_FS_ADDR 0x23
-#define ST_PRESS_1_FS_MASK 0x30
-#define ST_PRESS_1_FS_AVL_1260_VAL 0x00
-#define ST_PRESS_1_FS_AVL_1260_GAIN ST_PRESS_KPASCAL_NANO_SCALE
-#define ST_PRESS_1_FS_AVL_TEMP_GAIN ST_PRESS_CELSIUS_NANO_SCALE
-#define ST_PRESS_1_BDU_ADDR 0x20
-#define ST_PRESS_1_BDU_MASK 0x04
-#define ST_PRESS_1_DRDY_IRQ_ADDR 0x22
-#define ST_PRESS_1_DRDY_IRQ_INT1_MASK 0x04
-#define ST_PRESS_1_DRDY_IRQ_INT2_MASK 0x20
-#define ST_PRESS_1_MULTIREAD_BIT true
-#define ST_PRESS_1_TEMP_OFFSET 42500
+/* CUSTOM VALUES FOR LPS331AP SENSOR */
+#define ST_PRESS_LPS331AP_WAI_EXP 0xbb
+#define ST_PRESS_LPS331AP_ODR_ADDR 0x20
+#define ST_PRESS_LPS331AP_ODR_MASK 0x70
+#define ST_PRESS_LPS331AP_ODR_AVL_1HZ_VAL 0x01
+#define ST_PRESS_LPS331AP_ODR_AVL_7HZ_VAL 0x05
+#define ST_PRESS_LPS331AP_ODR_AVL_13HZ_VAL 0x06
+#define ST_PRESS_LPS331AP_ODR_AVL_25HZ_VAL 0x07
+#define ST_PRESS_LPS331AP_PW_ADDR 0x20
+#define ST_PRESS_LPS331AP_PW_MASK 0x80
+#define ST_PRESS_LPS331AP_FS_ADDR 0x23
+#define ST_PRESS_LPS331AP_FS_MASK 0x30
+#define ST_PRESS_LPS331AP_FS_AVL_1260_VAL 0x00
+#define ST_PRESS_LPS331AP_FS_AVL_1260_GAIN ST_PRESS_KPASCAL_NANO_SCALE
+#define ST_PRESS_LPS331AP_FS_AVL_TEMP_GAIN ST_PRESS_CELSIUS_NANO_SCALE
+#define ST_PRESS_LPS331AP_BDU_ADDR 0x20
+#define ST_PRESS_LPS331AP_BDU_MASK 0x04
+#define ST_PRESS_LPS331AP_DRDY_IRQ_ADDR 0x22
+#define ST_PRESS_LPS331AP_DRDY_IRQ_INT1_MASK 0x04
+#define ST_PRESS_LPS331AP_DRDY_IRQ_INT2_MASK 0x20
+#define ST_PRESS_LPS331AP_MULTIREAD_BIT true
+#define ST_PRESS_LPS331AP_TEMP_OFFSET 42500
+#define ST_PRESS_LPS331AP_OUT_XL_ADDR 0x28
+#define ST_TEMP_LPS331AP_OUT_L_ADDR 0x2b
static const struct iio_chan_spec st_press_channels[] = {
ST_SENSORS_LSM_CHANNELS(IIO_PRESSURE,
BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE),
ST_SENSORS_SCAN_X, 0, IIO_NO_MOD, 'u', IIO_LE, 24, 24,
- ST_PRESS_DEFAULT_OUT_XL_ADDR),
+ ST_PRESS_LPS331AP_OUT_XL_ADDR),
ST_SENSORS_LSM_CHANNELS(IIO_TEMP,
BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE) |
BIT(IIO_CHAN_INFO_OFFSET),
-1, 0, IIO_NO_MOD, 's', IIO_LE, 16, 16,
- ST_TEMP_DEFAULT_OUT_L_ADDR),
+ ST_TEMP_LPS331AP_OUT_L_ADDR),
IIO_CHAN_SOFT_TIMESTAMP(1)
};
static const struct st_sensors st_press_sensors[] = {
{
- .wai = ST_PRESS_1_WAI_EXP,
+ .wai = ST_PRESS_LPS331AP_WAI_EXP,
.sensors_supported = {
[0] = LPS331AP_PRESS_DEV_NAME,
},
.ch = (struct iio_chan_spec *)st_press_channels,
.odr = {
- .addr = ST_PRESS_1_ODR_ADDR,
- .mask = ST_PRESS_1_ODR_MASK,
+ .addr = ST_PRESS_LPS331AP_ODR_ADDR,
+ .mask = ST_PRESS_LPS331AP_ODR_MASK,
.odr_avl = {
- { 1, ST_PRESS_1_ODR_AVL_1HZ_VAL, },
- { 7, ST_PRESS_1_ODR_AVL_7HZ_VAL, },
- { 13, ST_PRESS_1_ODR_AVL_13HZ_VAL, },
- { 25, ST_PRESS_1_ODR_AVL_25HZ_VAL, },
+ { 1, ST_PRESS_LPS331AP_ODR_AVL_1HZ_VAL, },
+ { 7, ST_PRESS_LPS331AP_ODR_AVL_7HZ_VAL, },
+ { 13, ST_PRESS_LPS331AP_ODR_AVL_13HZ_VAL, },
+ { 25, ST_PRESS_LPS331AP_ODR_AVL_25HZ_VAL, },
},
},
.pw = {
- .addr = ST_PRESS_1_PW_ADDR,
- .mask = ST_PRESS_1_PW_MASK,
+ .addr = ST_PRESS_LPS331AP_PW_ADDR,
+ .mask = ST_PRESS_LPS331AP_PW_MASK,
.value_on = ST_SENSORS_DEFAULT_POWER_ON_VALUE,
.value_off = ST_SENSORS_DEFAULT_POWER_OFF_VALUE,
},
.fs = {
- .addr = ST_PRESS_1_FS_ADDR,
- .mask = ST_PRESS_1_FS_MASK,
+ .addr = ST_PRESS_LPS331AP_FS_ADDR,
+ .mask = ST_PRESS_LPS331AP_FS_MASK,
.fs_avl = {
[0] = {
.num = ST_PRESS_FS_AVL_1260MB,
- .value = ST_PRESS_1_FS_AVL_1260_VAL,
- .gain = ST_PRESS_1_FS_AVL_1260_GAIN,
- .gain2 = ST_PRESS_1_FS_AVL_TEMP_GAIN,
+ .value = ST_PRESS_LPS331AP_FS_AVL_1260_VAL,
+ .gain = ST_PRESS_LPS331AP_FS_AVL_1260_GAIN,
+ .gain2 = ST_PRESS_LPS331AP_FS_AVL_TEMP_GAIN,
},
},
},
.bdu = {
- .addr = ST_PRESS_1_BDU_ADDR,
- .mask = ST_PRESS_1_BDU_MASK,
+ .addr = ST_PRESS_LPS331AP_BDU_ADDR,
+ .mask = ST_PRESS_LPS331AP_BDU_MASK,
},
.drdy_irq = {
- .addr = ST_PRESS_1_DRDY_IRQ_ADDR,
- .mask_int1 = ST_PRESS_1_DRDY_IRQ_INT1_MASK,
- .mask_int2 = ST_PRESS_1_DRDY_IRQ_INT2_MASK,
+ .addr = ST_PRESS_LPS331AP_DRDY_IRQ_ADDR,
+ .mask_int1 = ST_PRESS_LPS331AP_DRDY_IRQ_INT1_MASK,
+ .mask_int2 = ST_PRESS_LPS331AP_DRDY_IRQ_INT2_MASK,
},
- .multi_read_bit = ST_PRESS_1_MULTIREAD_BIT,
+ .multi_read_bit = ST_PRESS_LPS331AP_MULTIREAD_BIT,
.bootime = 2,
},
};
--
1.8.1.2
next prev parent reply other threads:[~2013-09-10 12:50 UTC|newest]
Thread overview: 100+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-10 12:49 [PATCH v3 00/38] iio: ST clean-ups and new sensor support Lee Jones
2013-09-10 12:49 ` [PATCH 01/38] ARM: ux500: Remove PrimeCell IDs from Nomadik I2C DT nodes Lee Jones
2013-09-10 15:23 ` Olof Johansson
2013-09-10 15:30 ` Lee Jones
2013-09-10 12:49 ` [PATCH 02/38] ARM: ux500: Enable the LPS001WP Pressure & Temperature sensor from DT Lee Jones
2013-09-10 12:49 ` [PATCH 03/38] ARM: ux500: Enable the LSM303DLH Accelerator " Lee Jones
2013-09-10 12:49 ` [PATCH 04/38] ARM: ux500: Enable the LSM303DLH Magnetometer " Lee Jones
2013-09-10 12:49 ` [PATCH 05/38] ARM: ux500: Enable the L3G4200D Gyroscope " Lee Jones
2013-09-10 12:49 ` [PATCH 06/38] ARM: ux500: CONFIG: Enable ST's IIO Pressure Sensors by default Lee Jones
2013-09-10 12:49 ` [PATCH 07/38] ARM: ux500: CONFIG: Enable ST's IIO Accelerometer " Lee Jones
2013-09-10 15:20 ` Olof Johansson
2013-09-10 15:35 ` Lee Jones
2013-09-10 16:51 ` Olof Johansson
2013-09-11 7:20 ` Lee Jones
2013-09-10 12:49 ` [PATCH 08/38] ARM: ux500: CONFIG: Enable ST's IIO Magnetometer " Lee Jones
2013-09-10 12:49 ` [PATCH 09/38] ARM: ux500: CONFIG: Enable ST's IIO Gyroscope " Lee Jones
2013-09-10 12:49 ` [PATCH 10/38] Documentation: dt: iio: Add binding for LPS001WP Lee Jones
2013-09-14 12:08 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 11/38] Documentation: dt: iio: Add binding for LSM303DLH Lee Jones
2013-09-14 12:09 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 12/38] Documentation: dt: iio: Add binding for L3G4200D Lee Jones
2013-09-14 12:09 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 13/38] Documentation: dt: iio: Add binding for LSM303DLH Lee Jones
2013-09-14 12:09 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 14/38] iio: accel: st: Append _accel to accelerator sensor device names Lee Jones
2013-09-14 12:14 ` Jonathan Cameron
2013-09-14 12:27 ` Jonathan Cameron
2013-09-16 8:33 ` Lars-Peter Clausen
2013-09-16 9:21 ` Denis CIOCCA
2013-09-16 12:03 ` Lars-Peter Clausen
2013-09-16 19:15 ` Jonathan Cameron
2013-09-16 13:31 ` Lee Jones
2013-09-16 13:43 ` Lars-Peter Clausen
2013-09-16 19:17 ` Jonathan Cameron
2013-09-17 8:05 ` Lee Jones
2013-09-10 12:49 ` [PATCH 15/38] iio: gyro: st: Append _gyro to gyroscope " Lee Jones
2013-09-10 12:49 ` [PATCH 16/38] iio: magn: st: Append _magn to magnetometer " Lee Jones
2013-09-10 12:49 ` [PATCH 17/38] iio: press: st: Append _press to pressure " Lee Jones
2013-09-10 12:49 ` [PATCH 18/38] iio: sensors-core: st: Allow full-scale to be an optional feature Lee Jones
2013-09-14 16:45 ` Jonathan Cameron
2013-09-14 17:07 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 19/38] iio: sensors-core: st: Support sensors which don't have a Data Ready pin Lee Jones
2013-09-14 16:53 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 20/38] iio: sensors-core: st: Clean-up error handling in st_sensors_init_sensor() Lee Jones
2013-09-14 16:54 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 21/38] iio: sensors-core: st: Clean-up error handling in st_sensors_read_axis_data() Lee Jones
2013-09-14 16:58 ` Jonathan Cameron
2013-09-16 8:22 ` Lee Jones
2013-09-10 12:49 ` [PATCH 22/38] iio: sensors-core: st: Clean-up error handling in st_sensors_read_info_raw() Lee Jones
2013-09-14 17:01 ` Jonathan Cameron
2013-09-10 12:49 ` Lee Jones [this message]
2013-09-14 17:09 ` [PATCH 23/38] iio: pressure-core: st: Describe LPS331AP defines by name Jonathan Cameron
2013-09-10 12:49 ` [PATCH 24/38] iio: pressure-core: st: Expand and rename LPS331AP's channel descriptor Lee Jones
2013-09-14 17:14 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 25/38] iio: pressure-core: st: Allow for number of channels to vary Lee Jones
2013-09-14 17:18 ` Jonathan Cameron
2013-09-16 8:17 ` Lee Jones
2013-09-16 15:32 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 26/38] iio: pressure-core: st: Clean-up probe() function Lee Jones
2013-09-10 16:23 ` Jonathan Cameron
2013-09-11 7:19 ` Lee Jones
2013-09-14 17:21 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 27/38] iio: pressure-core: st: Give some indication if device probing was successful Lee Jones
2013-09-10 16:25 ` Jonathan Cameron
2013-09-11 7:10 ` Lee Jones
2013-09-11 7:18 ` Lars-Peter Clausen
2013-09-11 7:29 ` Lee Jones
2013-09-11 15:35 ` Mark Brown
2013-09-13 20:57 ` Getz, Robin
2013-09-16 9:47 ` Lee Jones
2013-09-11 18:30 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 28/38] iio: pressure: st: Add support for new LPS001WP pressure sensor Lee Jones
2013-09-14 17:26 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 29/38] iio: pressure-core: st: Provide support for the Vdd power supply Lee Jones
2013-09-14 17:28 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 30/38] iio: pressure-core: st: Provide support for the Vdd_IO " Lee Jones
2013-09-10 12:49 ` [PATCH 31/38] iio: accel-core: st: Clean up error handling in probe() Lee Jones
2013-09-14 17:31 ` Jonathan Cameron
2013-09-10 12:49 ` [PATCH 32/38] iio: accel-core: st: Move LSM303DLH into correct group Lee Jones
2013-09-14 17:51 ` Jonathan Cameron
2013-09-16 8:05 ` Lee Jones
2013-09-16 9:19 ` Denis CIOCCA
2013-09-16 9:38 ` Lee Jones
2013-09-16 9:57 ` Denis CIOCCA
2013-09-16 10:19 ` Lee Jones
2013-09-16 10:23 ` Denis CIOCCA
2013-09-16 11:08 ` Lee Jones
2013-09-10 12:49 ` [PATCH 33/38] iio: accel-core: st: Give some indication if device probing was successful Lee Jones
2013-09-10 12:49 ` [PATCH 34/38] iio: gyro-core: st: Clean up error handling in probe() Lee Jones
2013-09-10 12:49 ` [PATCH 35/38] iio: gyro-core: st: Give some indication if device probing was successful Lee Jones
2013-09-10 12:49 ` [PATCH 36/38] iio: magn-core: st: Clean up error handling in probe() Lee Jones
2013-09-10 12:49 ` [PATCH 37/38] iio: magn-core: st: Give some indication if device probing was successful Lee Jones
2013-09-10 12:49 ` [PATCH 38/38] iio: magn-core: st: Provide support for the LSM303DLH Lee Jones
2013-09-14 17:53 ` Jonathan Cameron
2013-09-16 7:31 ` Lee Jones
2013-09-16 9:32 ` Denis CIOCCA
2013-09-16 10:08 ` Lee Jones
2013-09-16 10:18 ` Denis CIOCCA
2013-09-16 11:11 ` Lee Jones
2013-09-16 11:26 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378817379-8238-24-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=denis.ciocca@st.com \
--cc=jic23@cam.ac.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).