From: Lars-Peter Clausen <lars@metafoo.de>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH v2 5/5] iio:buffer: Ignore noop requests for iio_update_buffers()
Date: Fri, 4 Oct 2013 13:07:02 +0200 [thread overview]
Message-ID: <1380884822-17035-5-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1380884822-17035-1-git-send-email-lars@metafoo.de>
Since the kernel now disables all buffers when a device is unregistered it might
happen that a in-kernel consumer tries to disable that buffer again. So ignore
requests where the buffer already is in the desired state.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
No changes since v1
---
drivers/iio/industrialio-buffer.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c
index d6a5455..fd3f3af 100644
--- a/drivers/iio/industrialio-buffer.c
+++ b/drivers/iio/industrialio-buffer.c
@@ -681,9 +681,23 @@ int iio_update_buffers(struct iio_dev *indio_dev,
{
int ret;
+ if (insert_buffer == remove_buffer)
+ return 0;
+
mutex_lock(&indio_dev->info_exist_lock);
mutex_lock(&indio_dev->mlock);
+ if (insert_buffer && iio_buffer_is_active(insert_buffer))
+ insert_buffer = NULL;
+
+ if (remove_buffer && !iio_buffer_is_active(remove_buffer))
+ remove_buffer = NULL;
+
+ if (!insert_buffer && !remove_buffer) {
+ ret = 0;
+ goto out_unlock;
+ }
+
if (indio_dev->info == NULL) {
ret = -ENODEV;
goto out_unlock;
--
1.8.0
next prev parent reply other threads:[~2013-10-04 11:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 11:06 [PATCH v2 1/5] iio: Add reference counting for buffers Lars-Peter Clausen
2013-10-04 11:06 ` [PATCH v2 2/5] iio: Return -ENODEV for file operations if the device has been unregistered Lars-Peter Clausen
2013-10-12 11:04 ` Jonathan Cameron
2013-10-04 11:07 ` [PATCH v2 3/5] iio: Wakeup poll and blocking reads when the device is unregistered Lars-Peter Clausen
2013-10-12 11:06 ` Jonathan Cameron
2013-10-04 11:07 ` [PATCH v2 4/5] iio:buffer: Add proper locking for iio_update_buffers() Lars-Peter Clausen
2013-10-12 11:07 ` Jonathan Cameron
2013-10-04 11:07 ` Lars-Peter Clausen [this message]
2013-10-12 11:10 ` [PATCH v2 5/5] iio:buffer: Ignore noop requests " Jonathan Cameron
2013-10-12 10:19 ` Lars-Peter Clausen
2013-10-12 12:06 ` Jonathan Cameron
2013-10-12 12:06 ` Jonathan Cameron
2013-10-12 11:00 ` [PATCH v2 1/5] iio: Add reference counting for buffers Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380884822-17035-5-git-send-email-lars@metafoo.de \
--to=lars@metafoo.de \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).