linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sachin Kamat <sachin.kamat@linaro.org>
To: linux-iio@vger.kernel.org
Cc: jic23@kernel.org, sachin.kamat@linaro.org
Subject: [PATCH 1/9] iio: core: Use pr_err instead of printk
Date: Thu, 24 Oct 2013 17:23:27 +0530	[thread overview]
Message-ID: <1382615615-20153-1-git-send-email-sachin.kamat@linaro.org> (raw)

Use of pr_err is preferred to printk.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/iio/industrialio-core.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/industrialio-core.c b/drivers/iio/industrialio-core.c
index f721157..e4780b4 100644
--- a/drivers/iio/industrialio-core.c
+++ b/drivers/iio/industrialio-core.c
@@ -9,6 +9,8 @@
  * Based on elements of hwmon and input subsystems.
  */
 
+#define pr_fmt(fmt) "iio-core: " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/idr.h>
@@ -132,16 +134,13 @@ static int __init iio_init(void)
 	/* Register sysfs bus */
 	ret  = bus_register(&iio_bus_type);
 	if (ret < 0) {
-		printk(KERN_ERR
-		       "%s could not register bus type\n",
-			__FILE__);
+		pr_err("could not register bus type\n");
 		goto error_nothing;
 	}
 
 	ret = alloc_chrdev_region(&iio_devt, 0, IIO_DEV_MAX, "iio");
 	if (ret < 0) {
-		printk(KERN_ERR "%s: failed to allocate char dev region\n",
-		       __FILE__);
+		pr_err("failed to allocate char dev region\n");
 		goto error_unregister_bus_type;
 	}
 
@@ -951,7 +950,7 @@ struct iio_dev *iio_device_alloc(int sizeof_priv)
 		dev->id = ida_simple_get(&iio_ida, 0, 0, GFP_KERNEL);
 		if (dev->id < 0) {
 			/* cannot use a dev_err as the name isn't available */
-			printk(KERN_ERR "Failed to get id\n");
+			pr_err("failed to get device id\n");
 			kfree(dev);
 			return NULL;
 		}
-- 
1.7.9.5


             reply	other threads:[~2013-10-24 11:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-24 11:53 Sachin Kamat [this message]
2013-10-24 11:53 ` [PATCH 2/9] iio: core: Add misssing braces Sachin Kamat
2013-10-24 13:44   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 3/9] iio: accel: kxsd9: Remove redundant variable Sachin Kamat
2013-10-24 13:44   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 4/9] iio: adc: twl6030-gpadc: Remove redundant code Sachin Kamat
2013-10-24 13:49   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 5/9] iio: dac: ad5421: " Sachin Kamat
2013-10-24 13:51   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 6/9] iio: dac: ad5755: " Sachin Kamat
2013-10-24 13:51   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 7/9] iio: dac: max517: Remove redundant variable Sachin Kamat
2013-10-24 13:52   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 8/9] iio: dac: mcp4725: Remove redundant code Sachin Kamat
2013-10-24 13:53   ` Jonathan Cameron
2013-10-24 11:53 ` [PATCH 9/9] iio: light: vcnl4000: " Sachin Kamat
2013-10-24 13:53   ` Jonathan Cameron
2013-10-24 13:41 ` [PATCH 1/9] iio: core: Use pr_err instead of printk Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1382615615-20153-1-git-send-email-sachin.kamat@linaro.org \
    --to=sachin.kamat@linaro.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).