linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: sr@denx.de, knaack.h@gmx.de, Jonathan Cameron <jic23@kernel.org>
Subject: [PATCH V2 0/4]  iio: Minor cleanups to spear ADC driver followed by staging graduation.
Date: Sat, 15 Mar 2014 14:55:04 +0000	[thread overview]
Message-ID: <1394895308-19154-1-git-send-email-jic23@kernel.org> (raw)

Changes since V1. Fixed the issues Harmuk Knaack pointed out in patch 4
by dropping the unused variables and ensure mask was as it should be.

Previous description:
This driver has been reasonably clean since it was first merged within the
staging tree.  If it had been submitted after the IIO core was outside of
staging we might have taken it as is. I did a final review and the first 4
patches of this series rework various minor aspects of the driver.

Whilst it is a slow driver, the device tree matches at the lowest level seemed
a little unwise so the largest rework is concerned with centralising that
logic using a classic ops structure of function pointers.  The other large
change was to move to using the info_mask_shared_by_all approach to handle
sampling frequency.  This is something I am slowly propogating across the
whole tree, but might as well be done whilst we are looking at this driver.

I don't have hardware and whilst I think these are all changes that are
possible to easily verify by eye, a tested by would be most welcome!

Note this is the first driver I'm suggesting moving out of staging following
Greg's entirely reasonable question of 'What's wrong with the stuff that is
left?'  Any help with this sort of final cleanup and move would be most
welcome.

Jonathan

Jonathan Cameron (4):
  staging:iio:adc:spear adc - prefix defines to avoid namespace clashes.
  staging:iio:adc:spear_adc drop initialization of unused scan_type
  staging:iio:adc:spear_adc use info_mask_shared_by_all for samp freq
  iio:adc:spear_adc move out of staging

 drivers/iio/adc/Kconfig             |   8 +
 drivers/iio/adc/Makefile            |   1 +
 drivers/iio/adc/spear_adc.c         | 405 +++++++++++++++++++++++++++++++++
 drivers/staging/iio/adc/Kconfig     |   8 -
 drivers/staging/iio/adc/Makefile    |   1 -
 drivers/staging/iio/adc/spear_adc.c | 432 ------------------------------------
 6 files changed, 414 insertions(+), 441 deletions(-)
 create mode 100644 drivers/iio/adc/spear_adc.c
 delete mode 100644 drivers/staging/iio/adc/spear_adc.c

-- 
1.9.0


             reply	other threads:[~2014-03-15 14:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-15 14:55 Jonathan Cameron [this message]
2014-03-15 14:55 ` [PATCH 1/4] staging:iio:adc:spear adc - prefix defines to avoid namespace clashes Jonathan Cameron
2014-03-16  0:16   ` Hartmut Knaack
2014-03-30 18:15     ` Jonathan Cameron
2014-03-15 14:55 ` [PATCH 2/4] staging:iio:adc:spear_adc drop initialization of unused scan_type Jonathan Cameron
2014-03-15 14:55 ` [PATCH 3/4] staging:iio:adc:spear_adc use info_mask_shared_by_all for samp freq Jonathan Cameron
2014-03-15 21:26   ` Hartmut Knaack
2014-03-30 18:11     ` Jonathan Cameron
2014-03-15 14:55 ` [PATCH 4/4] iio:adc:spear_adc move out of staging Jonathan Cameron
2014-03-16  0:25   ` Hartmut Knaack
2014-03-30 19:42     ` Jonathan Cameron
2014-03-31  7:13       ` Stefan Roese
2014-04-05 10:47         ` Jonathan Cameron
2014-04-05 15:17           ` Hartmut Knaack
2014-04-05 16:39             ` Jonathan Cameron
2017-02-05 12:27       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1394895308-19154-1-git-send-email-jic23@kernel.org \
    --to=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).