linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>
Cc: Milo.Kim@ti.com, Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
	Doug Anderson <dianders@chromium.org>,
	lee.jones@linaro.org, gregkh@linuxfoundation.org,
	Russ.Dill@ti.com, alexandre.belloni@free-electrons.com,
	oleksandr.kozaruk@ti.com, B38611@freescale.com,
	johannes.thumshirn@men.de, sre@debian.org,
	sachin.kamat@linaro.org, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH] iio: adc: Nothing in ADC should be a bool CONFIG
Date: Mon, 21 Apr 2014 17:03:51 -0700	[thread overview]
Message-ID: <1398125031-5826-1-git-send-email-dianders@chromium.org> (raw)

The whole IIO subsystem can be moved to a module.  If you make it a
module then stuff marked as "Y" in the adc directory simply won't be
linked in properly.

The two configs that were wrong were EXYNOS_ADC and LP8788_ADC.  I
know for a fact that EXYNOS_ADC will work as a module (though it
appears to crash when you unload it--that needs to be addressed
separately).  I assume LP8788_ADC will also be fine..

Signed-off-by: Doug Anderson <dianders@chromium.org>
---
 drivers/iio/adc/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index d86196c..24c28e3 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -106,7 +106,7 @@ config AT91_ADC
 	  Say yes here to build support for Atmel AT91 ADC.
 
 config EXYNOS_ADC
-	bool "Exynos ADC driver support"
+	tristate "Exynos ADC driver support"
 	depends on OF
 	help
 	  Core support for the ADC block found in the Samsung EXYNOS series
@@ -114,7 +114,7 @@ config EXYNOS_ADC
 	  this resource.
 
 config LP8788_ADC
-	bool "LP8788 ADC driver"
+	tristate "LP8788 ADC driver"
 	depends on MFD_LP8788
 	help
 	  Say yes here to build support for TI LP8788 ADC.
-- 
1.9.1.423.g4596e3a


             reply	other threads:[~2014-04-22  0:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-22  0:03 Doug Anderson [this message]
2014-04-23 20:54 ` [PATCH] iio: adc: Nothing in ADC should be a bool CONFIG Jonathan Cameron
2014-04-23 21:54   ` Doug Anderson
     [not found]     ` <5358951A.3080507@kernel.org>
2014-04-24 20:23       ` Doug Anderson
2014-04-26 10:30 ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398125031-5826-1-git-send-email-dianders@chromium.org \
    --to=dianders@chromium.org \
    --cc=B38611@freescale.com \
    --cc=Milo.Kim@ti.com \
    --cc=Russ.Dill@ti.com \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=ch.naveen@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=johannes.thumshirn@men.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleksandr.kozaruk@ti.com \
    --cc=sachin.kamat@linaro.org \
    --cc=sre@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).