linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Meerwald <pmeerw@pmeerw.net>
To: linux-iio@vger.kernel.org
Cc: jic23@kernel.org
Subject: [PATCH] iio: mma8452 driver
Date: Fri,  2 May 2014 10:51:34 +0200	[thread overview]
Message-ID: <1399020695-29822-1-git-send-email-pmeerw@pmeerw.net> (raw)

Hi,

I'm resending the Freescale Freescale MMA8452 accelerometer
driver, comments here:
http://permalink.gmane.org/gmane.linux.kernel.iio/10899

I only fixed the use of ARRAY_SIZE()

remaining items/comments are

(1) new reads cannot be explicitly triggered

in case a new measurement can or has to be triggered, there IS
some wait time (which can be rather long)

in case where we simply wait for the next measurement, there MAY BE
some wait time

so in both cases there can be wait time

I think the current approach it closer to the behaviour where
measurements are triggered explicitly

there is no concept of rate limit or measurement cache in IIO and
no guarantee how long a measurement will take (besides that it should
somehow be linked to sampling frequency)

(2) make sampling frequency an attribute of a dataready trigger?

the sampling frequency also affects read_raw() interaction, so I'd rather
keep it as it is


thanks, p.

Peter Meerwald (1):
  iio: Add Freescale MMA8452Q 3-axis accelerometer driver

 drivers/iio/accel/Kconfig   |  12 ++
 drivers/iio/accel/Makefile  |   1 +
 drivers/iio/accel/mma8452.c | 439 ++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 452 insertions(+)
 create mode 100644 drivers/iio/accel/mma8452.c

-- 
1.9.1

             reply	other threads:[~2014-05-02  8:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02  8:51 Peter Meerwald [this message]
2014-05-02  8:51 ` [PATCH] iio: Add Freescale MMA8452Q 3-axis accelerometer driver Peter Meerwald
2014-05-03 11:13   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399020695-29822-1-git-send-email-pmeerw@pmeerw.net \
    --to=pmeerw@pmeerw.net \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).