From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Stepan Ionichev <sozdayvek@gmail.com>,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v2] iio: pressure: rohm-bm1390: notify trigger on all error paths
Date: Thu, 4 Jun 2026 09:10:20 +0300 [thread overview]
Message-ID: <13c0720b-b96c-4bba-a673-0bc4a93ae767@gmail.com> (raw)
In-Reply-To: <ah3REJeg8KMB694A@ashevche-desk.local>
On 01/06/2026 21:36, Andy Shevchenko wrote:
> On Fri, May 29, 2026 at 11:21:40AM +0300, Matti Vaittinen wrote:
>> On 22/05/2026 15:38, Matti Vaittinen wrote:
>>> On 20/05/2026 14:08, Jonathan Cameron wrote:
>>>> On Tue, 19 May 2026 08:48:13 +0300
>>>> Matti Vaittinen <mazziesaccount@gmail.com> wrote:
>
> ...
>
>> +#ifdef TEST_FORCE_IRQ_NONE
>> + /* HACK, return IRQ_NONE and see if IRQ gets disabled */
>> + if (!(first2 % 1000))
>> + pr_info("Hack, return IRQ_NONE (%lu th)\n", first2);
>
> Hint: pr_info_ratelimited() seems better?
Thanks Andy. Yes, I suppose so. It's just that I _really_ rarely need
ratelimit prints. Hence I don't remember exact form of these print APIs
without checking for them. And it's easier to add a static counter (as a
unsafe debug hack) than search for the function signatures ;)
>> + first2++;
>> +
>> + return IRQ_NONE;
>> +#else
>> return IRQ_HANDLED;
>> +#endif
>
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
next prev parent reply other threads:[~2026-06-04 6:10 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 16:08 [PATCH] iio: pressure: rohm-bm1390: notify trigger on all error paths Stepan Ionichev
2026-05-17 17:12 ` David Lechner
2026-05-17 17:18 ` Stepan Ionichev
2026-05-18 5:21 ` Matti Vaittinen
2026-05-18 6:59 ` Andy Shevchenko
2026-05-18 7:35 ` Matti Vaittinen
2026-05-18 14:55 ` Jonathan Cameron
2026-05-18 18:31 ` Andy Shevchenko
2026-05-20 10:39 ` Jonathan Cameron
2026-05-18 14:50 ` Jonathan Cameron
2026-05-18 6:54 ` Andy Shevchenko
2026-05-18 9:42 ` [PATCH v2] " Stepan Ionichev
2026-05-18 10:42 ` Andy Shevchenko
2026-05-18 13:06 ` Matti Vaittinen
2026-05-18 15:15 ` Jonathan Cameron
2026-05-19 5:48 ` Matti Vaittinen
2026-05-20 11:08 ` Jonathan Cameron
2026-05-22 12:38 ` Matti Vaittinen
2026-05-29 8:21 ` Matti Vaittinen
2026-06-01 18:36 ` Andy Shevchenko
2026-06-04 6:10 ` Matti Vaittinen [this message]
2026-06-03 17:26 ` Jonathan Cameron
2026-06-04 6:05 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13c0720b-b96c-4bba-a673-0bc4a93ae767@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sozdayvek@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox