From: Joe Perches <joe@perches.com>
To: Federico Di Pierro <nierro92@gmail.com>
Cc: jic23@kernel.org, gregkh@linuxfoundation.org,
jg1.han@samsung.com, sachin.kamat@linaro.org,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c
Date: Mon, 02 Jun 2014 10:14:12 -0700 [thread overview]
Message-ID: <1401729252.5770.13.camel@joe-AO725> (raw)
In-Reply-To: <538CAEBD.5040501@gmail.com>
On Mon, 2014-06-02 at 19:05 +0200, Federico Di Pierro wrote:
> Hi!
Hello Federico.
> This is my latest task of the eudyptula challenge.
Your patch subject should be something like:
[PATCH] staging: iio: kernel style neatening
> Just a very small patch! It fixes 3 little coding style problems.
> I'm using linux-next.
linux/drivers/staging/iio/frequency/ad9832.c
[]
@@ -73,7 +73,7 @@ static int ad9832_write_phase(struct ad9
}
static ssize_t ad9832_write(struct device *dev,
- struct device_attribute *attr,
+ struct device_attribute *attr,
const char *buf,
size_t len)
checkpatch is a brainless little tool.
Please make sure your own brain is engaged when
acting on or verifying any warnings it emits.
Please expand the indented line range to include
all the arguments of the function.
next prev parent reply other threads:[~2014-06-02 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 17:05 [PATCH] fix some coding style problem in drivers/staging/iio/frequency/ad9832.c Federico Di Pierro
2014-06-02 17:14 ` Joe Perches [this message]
2014-06-02 17:21 ` Jianyu Zhan
2014-06-02 17:44 ` Jonathan Cameron
2014-06-02 19:10 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1401729252.5770.13.camel@joe-AO725 \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jg1.han@samsung.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nierro92@gmail.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).