linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Meerwald <pmeerw@pmeerw.net>
To: linux-iio@vger.kernel.org
Cc: jic23@kernel.org, Peter Meerwald <pmeerw@pmeerw.net>
Subject: [PATCH 10/12] staging:iio: Fix error handling in generic_buffer example
Date: Sat,  7 Jun 2014 17:42:50 +0200	[thread overview]
Message-ID: <1402155772-1373-11-git-send-email-pmeerw@pmeerw.net> (raw)
In-Reply-To: <1402155772-1373-1-git-send-email-pmeerw@pmeerw.net>

read() does not return -EAGAIN
read() returns -1 and the errno value needs to be checked for -EAGAIN

Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
 drivers/staging/iio/Documentation/generic_buffer.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/iio/Documentation/generic_buffer.c b/drivers/staging/iio/Documentation/generic_buffer.c
index 40d0eca..044ea19 100644
--- a/drivers/staging/iio/Documentation/generic_buffer.c
+++ b/drivers/staging/iio/Documentation/generic_buffer.c
@@ -305,9 +305,12 @@ int main(int argc, char **argv)
 		read_size = read(fp,
 				 data,
 				 toread*scan_size);
-		if (read_size == -EAGAIN) {
-			printf("nothing available\n");
-			continue;
+		if (read_size < 0) {
+			if (errno == -EAGAIN) {
+				printf("nothing available\n");
+				continue;
+			} else
+				break;
 		}
 		for (i = 0; i < read_size/scan_size; i++)
 			process_scan(data + scan_size*i,
-- 
1.9.1


  parent reply	other threads:[~2014-06-07 15:43 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-07 15:42 [PATCH 00/12] misc IIO cleanup Peter Meerwald
2014-06-07 15:42 ` [PATCH 01/12] iio:adc:ad5791: Use BIT() and GENMASK() macros Peter Meerwald
2014-06-09 11:58   ` Lars-Peter Clausen
2014-06-07 15:42 ` [PATCH 02/12] iio:adc:ad5504: " Peter Meerwald
2014-06-07 15:42 ` [PATCH 03/12] iio:adc:ad7887: " Peter Meerwald
2014-06-09 11:59   ` Lars-Peter Clausen
2014-06-07 15:42 ` [PATCH 04/12] iio:adc:ad7476: Use GENMASK() macro Peter Meerwald
2014-06-09 12:00   ` Lars-Peter Clausen
2014-06-07 15:42 ` [PATCH 05/12] iio:adc:ad7298: Use BIT() and GENMASK() macros Peter Meerwald
2014-06-09 12:00   ` Lars-Peter Clausen
2014-06-07 15:42 ` [PATCH 06/12] iio: Move documentation of iio-trig-sysfs to ABI Peter Meerwald
2014-06-09 19:58   ` Jonathan Cameron
2014-06-07 15:42 ` [PATCH 07/12] staging:iio: Update iio_event_monitor program Peter Meerwald
2014-06-07 15:42 ` [PATCH 08/12] staging:iio: Fix iio_utils.h function prototypes Peter Meerwald
2014-06-07 15:42 ` [PATCH 09/12] staging:iio: Fix mention of INDIO_RING_TRIGGERED to INDIO_BUFFER_TRIGGERED Peter Meerwald
2014-06-07 15:42 ` Peter Meerwald [this message]
2014-06-07 15:42 ` [PATCH 11/12] staging:iio-trig-periodic-rtc: Cleanup Peter Meerwald
2014-06-09 20:02   ` Jonathan Cameron
2014-06-09 20:04     ` Peter Meerwald
2014-06-09 20:14       ` Jonathan Cameron
2014-06-07 15:42 ` [PATCH 12/12] staging:iio-trig-periodic-rtc: Allow to reset frequency to 0 Peter Meerwald
2014-06-09 20:05 ` [PATCH 00/12] misc IIO cleanup Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1402155772-1373-11-git-send-email-pmeerw@pmeerw.net \
    --to=pmeerw@pmeerw.net \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).