linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] io: accel: kxcjk1013 Fix missing unlock errors
@ 2014-06-16 19:00 Srinivas Pandruvada
  0 siblings, 0 replies; only message in thread
From: Srinivas Pandruvada @ 2014-06-16 19:00 UTC (permalink / raw)
  To: jic23; +Cc: linux-iio, Srinivas Pandruvada

Fix unlock at two places. One when i2c error occurs and other
when trigger set state when raw read is in progress.

kbuild test robot errors:
>> drivers/iio/accel/kxcjk-1013.c:531:3-9: preceding lock on line 524
>> drivers/iio/accel/kxcjk-1013.c:376:4-10: preceding lock on line 368

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/accel/kxcjk-1013.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
index 2326e43..72a6dbb 100644
--- a/drivers/iio/accel/kxcjk-1013.c
+++ b/drivers/iio/accel/kxcjk-1013.c
@@ -372,8 +372,10 @@ static int kxcjk1013_read_raw(struct iio_dev *indio_dev,
 			int sleep_val;
 
 			ret = kxcjk1013_set_mode(data, OPERATION);
-			if (ret < 0)
+			if (ret < 0) {
+				mutex_unlock(&data->mutex);
 				return ret;
+			}
 			++data->power_state;
 			sleep_val = kxcjk1013_get_startup_times(data);
 			if (sleep_val < 20000)
@@ -527,8 +529,10 @@ static int kxcjk1013_data_rdy_trigger_set_state(struct iio_trigger *trig,
 		kxcjk1013_set_mode(data, OPERATION);
 		++data->power_state;
 	} else {
-		if (--data->power_state)
+		if (--data->power_state) {
+			mutex_unlock(&data->mutex);
 			return 0;
+		}
 		kxcjk1013_chip_setup_interrupt(data, false);
 		kxcjk1013_set_mode(data, STANDBY);
 	}
-- 
1.7.11.7

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-06-16 19:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 19:00 [PATCH] io: accel: kxcjk1013 Fix missing unlock errors Srinivas Pandruvada

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).