* [PATCH] iio: AK09911 : Remove duplicate indio_dev->name assignment
@ 2014-06-16 19:01 Srinivas Pandruvada
2014-06-16 19:55 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Srinivas Pandruvada @ 2014-06-16 19:01 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, Srinivas Pandruvada
Need to remove indio_dev->name assignment for id->name as id can
be NULL. Copy paste bug from ak8975.c where it was fixed later.
kbuild test robot errors:
error: we previously assumed 'id' could be null (see line 288)
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/iio/magnetometer/ak09911.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/iio/magnetometer/ak09911.c b/drivers/iio/magnetometer/ak09911.c
index 62f980c..b2bc942 100644
--- a/drivers/iio/magnetometer/ak09911.c
+++ b/drivers/iio/magnetometer/ak09911.c
@@ -298,7 +298,6 @@ static int ak09911_probe(struct i2c_client *client,
indio_dev->channels = ak09911_channels;
indio_dev->num_channels = ARRAY_SIZE(ak09911_channels);
indio_dev->info = &ak09911_info;
- indio_dev->name = id->name;
indio_dev->modes = INDIO_DIRECT_MODE;
indio_dev->name = name;
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: AK09911 : Remove duplicate indio_dev->name assignment
2014-06-16 19:01 [PATCH] iio: AK09911 : Remove duplicate indio_dev->name assignment Srinivas Pandruvada
@ 2014-06-16 19:55 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2014-06-16 19:55 UTC (permalink / raw)
To: Srinivas Pandruvada; +Cc: linux-iio
On 16/06/14 20:01, Srinivas Pandruvada wrote:
> Need to remove indio_dev->name assignment for id->name as id can
> be NULL. Copy paste bug from ak8975.c where it was fixed later.
>
> kbuild test robot errors:
> error: we previously assumed 'id' could be null (see line 288)
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Applied to the togreg branch of iio.git as a fixup to the original driver
patch (as that was last in the tree and I hadn't pushed it out properly yet ;)
Thanks,
> ---
> drivers/iio/magnetometer/ak09911.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/magnetometer/ak09911.c b/drivers/iio/magnetometer/ak09911.c
> index 62f980c..b2bc942 100644
> --- a/drivers/iio/magnetometer/ak09911.c
> +++ b/drivers/iio/magnetometer/ak09911.c
> @@ -298,7 +298,6 @@ static int ak09911_probe(struct i2c_client *client,
> indio_dev->channels = ak09911_channels;
> indio_dev->num_channels = ARRAY_SIZE(ak09911_channels);
> indio_dev->info = &ak09911_info;
> - indio_dev->name = id->name;
> indio_dev->modes = INDIO_DIRECT_MODE;
> indio_dev->name = name;
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-16 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-16 19:01 [PATCH] iio: AK09911 : Remove duplicate indio_dev->name assignment Srinivas Pandruvada
2014-06-16 19:55 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).