From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Srinivas Pandruvada To: jic23@kernel.org Cc: linux-iio@vger.kernel.org, Srinivas Pandruvada Subject: [PATCH 4/8] iio: hid_sensor_hub: Remove indio_dev->trig assignment Date: Fri, 11 Jul 2014 10:12:15 -0700 Message-Id: <1405098739-25470-4-git-send-email-srinivas.pandruvada@linux.intel.com> In-Reply-To: <1405098739-25470-1-git-send-email-srinivas.pandruvada@linux.intel.com> References: <1405098739-25470-1-git-send-email-srinivas.pandruvada@linux.intel.com> List-ID: This can result in wrong reference count for trigger device, leave the binding to user space via current_trigger sysfs entry. Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion with Jonathan. Signed-off-by: Srinivas Pandruvada --- drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c index a3109a6..5fdf475 100644 --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c @@ -122,7 +122,7 @@ int hid_sensor_setup_trigger(struct iio_dev *indio_dev, const char *name, dev_err(&indio_dev->dev, "Trigger Register Failed\n"); goto error_free_trig; } - indio_dev->trig = attrb->trigger = trig; + attrb->trigger = trig; return ret; -- 1.9.1