[PATCH 1/8] iio: accel: bma180: Remove indio_dev->trig assignment

[PATCH 1/8] iio: accel: bma180: Remove indio_dev->trig assignment

[Srinivas Pandruvada]

This can result in wrong reference count for trigger device, leave the binding
to user space via current_trigger sysfs entry.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/accel/bma180.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
index a7e68c8..1595065 100644
--- a/drivers/iio/accel/bma180.c
+++ b/drivers/iio/accel/bma180.c
@@ -569,7 +569,6 @@ static int bma180_probe(struct i2c_client *client,
 	trig->ops = &bma180_trigger_ops;
 	iio_trigger_set_drvdata(trig, indio_dev);
 	data->trig = trig;
-	indio_dev->trig = trig;
 
 	ret = iio_trigger_register(trig);
 	if (ret)
-- 
1.9.1

[PATCH 2/8] iio: accel: kxcjk-1013: Remove indio_dev->trig assignment

[Srinivas Pandruvada]

This can result in wrong reference count for trigger device, leave the binding
to user space via current_trigger sysfs entry.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/accel/kxcjk-1013.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c
index 72a6dbb..6a091f8 100644
--- a/drivers/iio/accel/kxcjk-1013.c
+++ b/drivers/iio/accel/kxcjk-1013.c
@@ -644,7 +644,6 @@ static int kxcjk1013_probe(struct i2c_client *client,
 		trig->ops = &kxcjk1013_trigger_ops;
 		iio_trigger_set_drvdata(trig, indio_dev);
 		data->trig = trig;
-		indio_dev->trig = trig;
 
 		ret = iio_trigger_register(trig);
 		if (ret)
-- 
1.9.1

[PATCH 3/8] iio: adc: ad_sigma_delta: Remove indio_dev->trig assignment

[Srinivas Pandruvada]

This can result in wrong reference count for trigger device, leave the binding
to user space via current_trigger sysfs entry.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/adc/ad_sigma_delta.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c
index c55b81f..966159e 100644
--- a/drivers/iio/adc/ad_sigma_delta.c
+++ b/drivers/iio/adc/ad_sigma_delta.c
@@ -471,9 +471,6 @@ static int ad_sd_probe_trigger(struct iio_dev *indio_dev)
 	if (ret)
 		goto error_free_irq;
 
-	/* select default trigger */
-	indio_dev->trig = sigma_delta->trig;
-
 	return 0;
 
 error_free_irq:
-- 
1.9.1

[PATCH 4/8] iio: hid_sensor_hub: Remove indio_dev->trig assignment

[Srinivas Pandruvada]

This can result in wrong reference count for trigger device, leave the binding
to user space via current_trigger sysfs entry.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
index a3109a6..5fdf475 100644
--- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
+++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c
@@ -122,7 +122,7 @@ int hid_sensor_setup_trigger(struct iio_dev *indio_dev, const char *name,
 		dev_err(&indio_dev->dev, "Trigger Register Failed\n");
 		goto error_free_trig;
 	}
-	indio_dev->trig = attrb->trigger = trig;
+	attrb->trigger = trig;
 
 	return ret;
 
-- 
1.9.1

[PATCH 5/8] iio: st_sensors: Remove indio_dev->trig assignment

[Srinivas Pandruvada]

This can result in wrong reference count for trigger device, leave the binding
to user space via current_trigger sysfs entry.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/common/st_sensors/st_sensors_trigger.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/common/st_sensors/st_sensors_trigger.c b/drivers/iio/common/st_sensors/st_sensors_trigger.c
index 8fc3a97..b64f514 100644
--- a/drivers/iio/common/st_sensors/st_sensors_trigger.c
+++ b/drivers/iio/common/st_sensors/st_sensors_trigger.c
@@ -49,7 +49,6 @@ int st_sensors_allocate_trigger(struct iio_dev *indio_dev,
 		dev_err(&indio_dev->dev, "failed to register iio trigger.\n");
 		goto iio_trigger_register_error;
 	}
-	indio_dev->trig = sdata->trig;
 
 	return 0;
 
-- 
1.9.1

[PATCH 6/8] iio: gyro: itg3200: Remove indio_dev->trig assignment

[Srinivas Pandruvada]

This can result in wrong reference count for trigger device, leave the binding
to user space via current_trigger sysfs entry.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/gyro/itg3200_buffer.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/iio/gyro/itg3200_buffer.c b/drivers/iio/gyro/itg3200_buffer.c
index e3b3c50..2ba20f6 100644
--- a/drivers/iio/gyro/itg3200_buffer.c
+++ b/drivers/iio/gyro/itg3200_buffer.c
@@ -131,9 +131,6 @@ int itg3200_probe_trigger(struct iio_dev *indio_dev)
 	if (ret)
 		goto error_free_irq;
 
-	/* select default trigger */
-	indio_dev->trig = st->trig;
-
 	return 0;
 
 error_free_irq:
-- 
1.9.1

[PATCH 7/8] iio: inv_mpu6050: Remove indio_dev->trig assignment

[Srinivas Pandruvada]

This can result in wrong reference count for trigger device, leave the binding
to user space via current_trigger sysfs entry.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
index 03b9372..57aabd4 100644
--- a/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
+++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_trigger.c
@@ -135,7 +135,6 @@ int inv_mpu6050_probe_trigger(struct iio_dev *indio_dev)
 	ret = iio_trigger_register(st->trig);
 	if (ret)
 		goto error_free_irq;
-	indio_dev->trig = st->trig;
 
 	return 0;
 
-- 
1.9.1

[PATCH 8/8] iio: meter: ade7758: Remove indio_dev->trig assignment

[Srinivas Pandruvada]

This can result in wrong reference count for trigger device, leave the binding
to user space via current_trigger sysfs entry.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
 drivers/staging/iio/meter/ade7758_trigger.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/iio/meter/ade7758_trigger.c b/drivers/staging/iio/meter/ade7758_trigger.c
index ea01b8f..3a98627 100644
--- a/drivers/staging/iio/meter/ade7758_trigger.c
+++ b/drivers/staging/iio/meter/ade7758_trigger.c
@@ -84,8 +84,6 @@ int ade7758_probe_trigger(struct iio_dev *indio_dev)
 	iio_trigger_set_drvdata(st->trig, indio_dev);
 	ret = iio_trigger_register(st->trig);
 
-	/* select default trigger */
-	indio_dev->trig = st->trig;
 	if (ret)
 		goto error_free_irq;
 
-- 
1.9.1

Re: [PATCH 1/8] iio: accel: bma180: Remove indio_dev->trig assignment

[Jonathan Cameron]

On 11/07/14 18:12, Srinivas Pandruvada wrote:
> This can result in wrong reference count for trigger device, leave the binding
> to user space via current_trigger sysfs entry.
> Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
> with Jonathan.
>
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
The issue here is that this is a userspace ABI change.  I'd have love
to not have had these there in the first place, but now they are.
I think a better change would be to simply add a call to iio_trigger_get
in all these cases. That way it's effectively the same as the
> ---
>   drivers/iio/accel/bma180.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/accel/bma180.c b/drivers/iio/accel/bma180.c
> index a7e68c8..1595065 100644
> --- a/drivers/iio/accel/bma180.c
> +++ b/drivers/iio/accel/bma180.c
> @@ -569,7 +569,6 @@ static int bma180_probe(struct i2c_client *client,
>   	trig->ops = &bma180_trigger_ops;
>   	iio_trigger_set_drvdata(trig, indio_dev);
>   	data->trig = trig;
> -	indio_dev->trig = trig;
>
>   	ret = iio_trigger_register(trig);
>   	if (ret)
>