From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: jic23@kernel.org
Cc: linux-iio@vger.kernel.org,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Subject: [PATCH 6/8] iio: gyro: itg3200: Remove indio_dev->trig assignment
Date: Fri, 11 Jul 2014 10:12:17 -0700 [thread overview]
Message-ID: <1405098739-25470-6-git-send-email-srinivas.pandruvada@linux.intel.com> (raw)
In-Reply-To: <1405098739-25470-1-git-send-email-srinivas.pandruvada@linux.intel.com>
This can result in wrong reference count for trigger device, leave the binding
to user space via current_trigger sysfs entry.
Refer to http://www.spinics.net/lists/linux-iio/msg13669.html for discussion
with Jonathan.
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
---
drivers/iio/gyro/itg3200_buffer.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/iio/gyro/itg3200_buffer.c b/drivers/iio/gyro/itg3200_buffer.c
index e3b3c50..2ba20f6 100644
--- a/drivers/iio/gyro/itg3200_buffer.c
+++ b/drivers/iio/gyro/itg3200_buffer.c
@@ -131,9 +131,6 @@ int itg3200_probe_trigger(struct iio_dev *indio_dev)
if (ret)
goto error_free_irq;
- /* select default trigger */
- indio_dev->trig = st->trig;
-
return 0;
error_free_irq:
--
1.9.1
next prev parent reply other threads:[~2014-07-11 17:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-11 17:12 [PATCH 1/8] iio: accel: bma180: Remove indio_dev->trig assignment Srinivas Pandruvada
2014-07-11 17:12 ` [PATCH 2/8] iio: accel: kxcjk-1013: " Srinivas Pandruvada
2014-07-11 17:12 ` [PATCH 3/8] iio: adc: ad_sigma_delta: " Srinivas Pandruvada
2014-07-11 17:12 ` [PATCH 4/8] iio: hid_sensor_hub: " Srinivas Pandruvada
2014-07-11 17:12 ` [PATCH 5/8] iio: st_sensors: " Srinivas Pandruvada
2014-07-11 17:12 ` Srinivas Pandruvada [this message]
2014-07-11 17:12 ` [PATCH 7/8] iio: inv_mpu6050: " Srinivas Pandruvada
2014-07-11 17:12 ` [PATCH 8/8] iio: meter: ade7758: " Srinivas Pandruvada
2014-07-13 9:06 ` [PATCH 1/8] iio: accel: bma180: " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1405098739-25470-6-git-send-email-srinivas.pandruvada@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).