From: Joe Perches <joe@perches.com>
To: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
jic23@kernel.org
Subject: Re: [PATCH v2 8/8] staging: iio: accel: sca3000_core.c: Add blank line between declarations and code
Date: Mon, 04 Aug 2014 19:02:19 -0700 [thread overview]
Message-ID: <1407204139.16152.106.camel@joe-AO725> (raw)
In-Reply-To: <1407203223-9700-9-git-send-email-mopsfelder@gmail.com>
On Mon, 2014-08-04 at 22:47 -0300, Murilo Opsfelder Araujo wrote:
> This patch adds missing blank line between declarations and code, and
> adjust code to fit 80-chars limit.
[]
> diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
[]
> @@ -506,7 +506,8 @@ static int sca3000_read_raw(struct iio_dev *indio_dev,
> mutex_unlock(&st->lock);
> return ret;
> }
> - *val = ((st->rx[0] & 0x3F) << 3) | ((st->rx[1] & 0xE0) >> 5);
> + *val = ((st->rx[0] & 0x3F) << 3)
> + | ((st->rx[1] & 0xE0) >> 5);
Please don't strain to fit 80 columns.
If this is done, please strive to make it
quickly intelligible for humans.
I think this would be better as:
+ *val = ((st->rx[0] & 0x3F) << 3) |
+ ((st->rx[1] & 0xE0) >> 5);
so that the mask and shift are aligned.
next prev parent reply other threads:[~2014-08-05 2:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 1:46 [PATCH v2 0/8] staging: iio: accel: Multiple coding style fixes Murilo Opsfelder Araujo
2014-08-05 1:46 ` [PATCH v2 1/8] staging: iio: accel: adis16203_core.c: Add blank lines between declarations and code Murilo Opsfelder Araujo
2014-08-05 1:46 ` [PATCH v2 2/8] staging: iio: accel: adis16201_core.c: Add blank line " Murilo Opsfelder Araujo
2014-08-05 1:46 ` [PATCH v2 3/8] staging: iio: accel: adis16204_core.c: " Murilo Opsfelder Araujo
2014-08-05 1:46 ` [PATCH v2 4/8] staging: iio: accel: adis16209_core.c: " Murilo Opsfelder Araujo
2014-08-05 1:47 ` [PATCH v2 5/8] staging: iio: accel: adis16240_core.c: " Murilo Opsfelder Araujo
2014-08-05 1:47 ` [PATCH v2 6/8] staging: iio: accel: lis3l02dq_core.c: Add blank lines " Murilo Opsfelder Araujo
2014-08-05 1:47 ` [PATCH v2 7/8] staging: iio: accel: lis3l02dq_ring.c: Add blank line " Murilo Opsfelder Araujo
2014-08-05 1:47 ` [PATCH v2 8/8] staging: iio: accel: sca3000_core.c: " Murilo Opsfelder Araujo
2014-08-05 2:02 ` Joe Perches [this message]
2014-08-05 10:24 ` [PATCH v2 0/8] staging: iio: accel: Multiple coding style fixes Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407204139.16152.106.camel@joe-AO725 \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mopsfelder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).